Ticket368practice - Githubissues

the-difference-engine / ksf

7 stars 1 forks source link

Ticket368practice #397

Closed Lcole490 closed 2 years ago

Lcole490 commented 2 years ago

Zenhub Link: https://app.zenhub.com/workspaces/ksf-5f23520d91f7ee00134cbaf6/issues/the-difference-engine/ksf/368

Describe the problem being solved: Linking new google drive folders and attachments to new application naming format

Impacted areas in the application: Frontend and Backend

Describe the steps you took to test your changes: Sent emails with attachments to confirm receipt and update of dashboard accordingly

If this ticket involves any UI or email changes, please provide a screenshot that shows the updated UI

List general components of the application that this PR will affect: Auth.js, Nomination.js, mailer.js, NominationsContext.js

PR checklist

[ x ] I have linked the PR to a Zenhub ticket
[ x ] I have checked for merge conflicts

aschey commented 2 years ago

I think this looks okay, but it seems like it has some of the same changes as 365, and I'm not entirely sure what the consequence of this change is. Can discuss more on Monday.