the-djmaze / snappymail

Simple, modern & fast web-based email client
https://snappymail.eu
GNU Affero General Public License v3.0
924 stars 109 forks source link

"Disable capabilities" - does a check indicate enabled or disabled? #1642

Closed jak closed 6 days ago

jak commented 1 week ago

Describe the bug

Within the domain popup modal, under the context of the heading "Disable capabilities" it is not clear whether a checked capability indicates whether or not is enabled or disabled.

image

If the intended behaviour can be made clear, I'd be happy to provide a PR to make the necessary change

To Reproduce Steps to reproduce the behavior:

  1. Go to Admin
  2. Go to Domains
  3. Click to add a domain

Expected behavior A clear and concise description of what you expected to happen.

A heading with "Server Capabilities" Possible additional description "Check the capabilities that this server supports" A ticked box indicates a valid capability

Screenshots If applicable, add screenshots to help explain your problem.

Please complete the following information:

Debug/logging information Read here how to log

Additional context Add any other context about the problem here.

the-djmaze commented 1 week ago

The heading says "disable" so when you check them, they will be disabled.

If it said "Enable capabilities" it would enable them.

Yes, it is on purpose to "disable".

https://github.com/the-djmaze/snappymail/wiki/IMAP-capabilities