search

the-djmaze / snappymail

Simple, modern & fast web-based email client
https://snappymail.eu
GNU Affero General Public License v3.0
1.01k stars 121 forks source link

`poppassd` for password change #351

Closed DerDanilo closed 2 years ago

DerDanilo commented 2 years ago

Is your feature request related to a problem? Please describe. Cannot change the password via webmailer on some systems without complex and constantly to mantain custom plugins.

Describe the solution you'd like Shared hosting systems like Plesk or cPanel already offer poppassd. Please support this as rainloop did.

Describe alternatives you've considered Using any of the given options in the password change plugin is not usable in these cases.

Additional context Rainloop had a simple plugin for that. https://github.com/RainLoop/rainloop-webmail/tree/master/plugins/poppassd-change-password

Thanks!

the-djmaze commented 2 years ago

You can test the plugin now

Also check #272 regarding a bug that might pop up

DerDanilo commented 2 years ago
grafik

AH01071: Got error 'PHP message: PHP Warning: Undefined variable $sLogin in /var/www/vhosts/.../.../data/_data_.../_default_/plugins/change-password-poppassd/driver.php on line 57PHP message: PHP Notice: ChangePasswordpoppassdDriver failed: UnknownNotification[130] in /var/www/vhosts/.../.../data/_data_.../_default_/plugins/change-password/index.php on line 183PHP message: PHP Notice: ChangePassword failed in /var/www/vhosts/.../.../data/_data_.../_default_/plugins/change-password/index.php on line 194PHP message: SERVICE WARNING: UnknownNotification[130]' |   |   |   | Apache-Fehler

It seems that the poppassd required to be installed as additional plugin and then be configured in the change password plugin. Wouldn't it make more sense to just integrate it into the password change plugin?

the-djmaze commented 2 years ago

Wouldn't it make more sense to just integrate it into the password change plugin?

Yes and no. It's currently there on purpose so that people know how to easily create their own change-password driver. If they upload their own driver to /change-password/drivers/ it would be gone with every plugin update.