search

the-djmaze / snappymail

Simple, modern & fast web-based email client
https://snappymail.eu
GNU Affero General Public License v3.0
1k stars 121 forks source link

update to 2.17.3 has completely broken Reply All #506

Closed jdaviescoates closed 2 years ago

jdaviescoates commented 2 years ago

Describe the bug Reply All is currently Reply None

To Reproduce Steps to reproduce the behavior:

  1. Go to a message within Snappymail
  2. Click on the menu hamburger top right
  3. Hit Reply All
  4. Note that zero email addresses are in the To field

Expected behavior When I hit Reply All I expect all the emails from the email I'm replying in to be in the To and/ or cc fields.

Please complete the following information:

Additional context This is on SnappyMail installed using Cloudron

codiflow commented 2 years ago

Totally confirm that.

I have a clean installed version without Cloudron and the issue is the same.

First thought it has something to do with the new "default settings" but changing some of them didn't change anything in behaviour.

The new window is completely empty – its not just not filling in the recipients, its also not filling in the Reply subject and the signature / email you are replying to: image

I also noticed (might be another issue) that the sender of an email is not clickable anymore after updating to 2.17.3: image

jdaviescoates commented 2 years ago

I'm guessing perhaps fixing replying to messages in sent items #497 might've somehow effected this?

the-djmaze commented 2 years ago

I'm guessing perhaps fixing replying to messages in sent items #497 might've somehow effected this?

Correct #497 changes caused the issue

codiflow commented 2 years ago

Unfortunately I can't "repair" the current installation using your commit. What am I doing wrong? I added the missing brackets like mentioned in your commit https://github.com/the-djmaze/snappymail/commit/3d5e094fd886de1b6dc30d478923b54bfdc535a8 to snappymail/v/2.17.3/static/js/app.js

Afterwards I created the two compressed files from the uncompressed one using

cat app.js | gzip > app.js.gz cat app.js | brotli > app.js.br chown www-data:www-data app.js.gz app.js.br

Then I reloaded my SnappyMail disarding the browsers cache – but the behaviour didn't change.

codiflow commented 2 years ago

I'm getting the following error in the browsers console:

17:41:01.029 Uncaught TypeError: e.map is not a function
    vr https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    initOnShow https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    onShow https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    Ei https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    showMessageComposer https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    Ds https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    replyOrforward https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    t https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    s https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    init https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    init https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    L https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    L https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    init https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    init https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    init https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    a https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    N https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    a https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    a https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    n https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    t https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    n https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    t https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    n https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    t https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    n https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    t https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    n https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    t https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    n https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    t https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    n https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    t https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    n https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    t https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    vb https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    init https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    ac https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    P https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    Cb https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    s https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    s https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    La https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    t https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    MailMessageList https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    itemSelected https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    o https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    t https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    setTimeout handler*Function.prototype.debounce/< https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    Selector https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    s https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    s https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    La https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    t https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    selectMessageItem https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    actionClick https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    click https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    y https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    y https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    init https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    onBuild https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    bi https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    vi https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    vi https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    parse https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    l https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    l https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    init https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/libs.min.js:1
    Fi https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    start https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    ei https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    promise callback*ei https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    start https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    bootstart https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    bootstart https://mail.mydomain.de/snappymail/v/2.17.3/static/js/min/app.min.js:1
    d https://mail.mydomain.de/#/mailbox/INBOX:56
    initData https://mail.mydomain.de/#/mailbox/INBOX:56
    promise callback*initData https://mail.mydomain.de/#/mailbox/INBOX:56
    <anonymous> https://mail.mydomain.de/?/AppData/0/7904745246220926/:1
app.min.js:1:164954
codiflow commented 2 years ago

Ok nevermind – got it fixed. There also need to be stuff replaced in the min folder... Haven't seen that. Can confirm the bug has been fixed with the commit.

Just copied the non-minified versions to the min-folder as a quick-and-dirty solution until the new release comes out.