the-djmaze / snappymail

Simple, modern & fast web-based email client
https://snappymail.eu
GNU Affero General Public License v3.0
1.02k stars 122 forks source link

Nextcloud theme is dark by defualt while the user theme is Light #620

Closed elhananjair closed 1 year ago

elhananjair commented 2 years ago

Describe the bug I have a light theme applied on nextcloud, and I selected Nextcloud theme snappymail setting. By default, it is dark, but currently I am using Light theme therefore it doesn't look nice.

To Reproduce Steps to reproduce the behavior:

  1. Go to setting
  2. Click on themes
  3. Select Nextcloud from the theme list
  4. The dark background color appears

Expected behavior Should be the same with Nextcloud applied theme

Screenshots Screenshot from 2022-11-03 23-28-38 Please complete the following information:

Debug/logging information Place them here (few lines) or as attachments (many lines)

Additional context Add any other context about the problem here.

the-djmaze commented 2 years ago

SnappyMail 2.20 uses var() settings in CSS of your theme. So your theme might have issues.

Try Nextcloud default or Breeze Dark.

Also report which Nextcloud theme you are using.

elhananjair commented 1 year ago

@the-djmaze as you might see in the pic am using Nextcloud theme on snappy mail and the Light theme on Nextcloud.

the-djmaze commented 1 year ago

Right. Where do you set the default to Dark? Because i can't find that option in my Nextcloud

the-djmaze commented 1 year ago

Did you try the embed mode?

the-djmaze commented 1 year ago

Ah, you are using Nextcloud 25. Because everything works fine in Nextcloud 24.

So i went and installed Nextcloud 25 and i noticed that the theme of NC25 is horrible.

You should report to Nextcloud that there is something wrong with the :root variables.

Because SnappyMail just maps its own variables to that of Nextcloud. Like:

:root {
    --main-bg-color: var(--color-main-background)
}

But --color-main-background is black, not white in NC25

The issue is the way how NC25 controls theme colors

[data-theme-light] {
    --color-main-background: #fff;
}
the-djmaze commented 1 year ago

Fixed in v2.20.1