the-djmaze / snappymail

Simple, modern & fast web-based email client
https://snappymail.eu
GNU Affero General Public License v3.0
1.01k stars 121 forks source link

bad call of SnappyMail\Log::warning() in libraries/RainLoop/Config/Application.php #663

Closed Viqsi closed 1 year ago

Viqsi commented 1 year ago

While trying to install Snappymail for the first time, I was running into some issues with being unable to configure it due to server errors. I've not pinned that down, but there is one glaringly obvious error that the server log has pointed at:

Exception: Too few arguments to function SnappyMail\Log::warning(), 1 passed in /var/www/nextcloud/apps/snappymail/app/snappymail/v/2.21.0/app/libraries/RainLoop/Config/Application.php on line 44 and exactly 2 expected in file '/var/www/nextcloud/apps/snappymail/app/snappymail/v/2.21.0/app/libraries/snappymail/log.php' line 16

A quick grep through the plugin source suggests this is the only place where SnappyMail\Log::warning() gets only one argument. I'm not sure what the first parameter ought to be (I "patched" it locally by just putting in a first parameter of "config"), so this is a bug report rather than a pull request.

the-djmaze commented 1 year ago

Is fixed in https://github.com/the-djmaze/snappymail/commit/e7958fb1edc082581ebf29114bbccfb04eab7231