the-djmaze / snappymail

Simple, modern & fast web-based email client
https://snappymail.eu
GNU Affero General Public License v3.0
1.01k stars 121 forks source link

Avatars plugin 1.3 results in error #741

Closed yasuhirokimura closed 1 year ago

yasuhirokimura commented 1 year ago

After updating avatars plugin to 1.3, following messages are displayed and SnappyMail doesn't work any more.

Warning: Array to string conversion in /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/RainLoop/Config/AbstractConfig.php on line 96

Warning: Cannot modify header information - headers already sent by (output started at /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/RainLoop/Config/AbstractConfig.php:96) in /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/snappymail/http/csp.php on line 68

Warning: Cannot modify header information - headers already sent by (output started at /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/RainLoop/Config/AbstractConfig.php:96) in /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/RainLoop/Service.php on line 40

Warning: Cannot modify header information - headers already sent by (output started at /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/RainLoop/Config/AbstractConfig.php:96) in /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/RainLoop/Service.php on line 142

Warning: Cannot modify header information - headers already sent by (output started at /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/RainLoop/Config/AbstractConfig.php:96) in /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/MailSo/Base/Http.php on line 219

Warning: Cannot modify header information - headers already sent by (output started at /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/RainLoop/Config/AbstractConfig.php:96) in /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/MailSo/Base/Http.php on line 220

Warning: Cannot modify header information - headers already sent by (output started at /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/RainLoop/Config/AbstractConfig.php:96) in /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/MailSo/Base/Http.php on line 221

Warning: Cannot modify header information - headers already sent by (output started at /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/RainLoop/Config/AbstractConfig.php:96) in /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/MailSo/Base/Http.php on line 222

Warning: Cannot modify header information - headers already sent by (output started at /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/RainLoop/Config/AbstractConfig.php:96) in /usr/local/www/snappymail/snappymail/v/2.22.5/app/libraries/snappymail/http/csp.php on line 68

If I remove the plugin then SnappyMail works fine again.

the-djmaze commented 1 year ago

Problem is not the plugin, but a strange quirk in RainLoop to handle SELECT vs scalar values. This was not a real problem until i moved to save as JSON.

So i've changed the core to save SELECT options in a property as it should vs DefaultValue.