search

the-dr-lazy / deox

Functional Type-safe Flux Standard Utilities
https://deox.js.org
MIT License
206 stars 12 forks source link

chore: add ts-jest testing config and scripts #126

Closed kotarella1110 closed 4 years ago

kotarella1110 commented 4 years ago

The current tests are not run properly. The cause of tests not running is removed ts-jest by this commit.

Both jest-runner-tsc and ts-jest are required. Please see below for the details.

https://github.com/azz/jest-runner-tsc/issues/6#issuecomment-395934357

They are different things :) ts-jest is to transform TS code into JS. jest-runner-tsc doesn't run tests, it runs the TS typechecker, so it's like a linter. You need to run both.

kotarella1110 commented 4 years ago

Once this pull request is merged, I can create a PR for #87 !

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8b0bbce). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #126   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      9           
  Lines             ?     49           
  Branches          ?      9           
=======================================
  Hits              ?     49           
  Misses            ?      0           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b0bbce...26392f0. Read the comment docs.

kotarella1110 commented 4 years ago

What you are saying is correct! completed 👍

the-dr-lazy commented 4 years ago

Merged with honor @kotarella1110.