search

the-dr-lazy / deox

Functional Type-safe Flux Standard Utilities
https://deox.js.org
MIT License
206 stars 12 forks source link

feat: add isOfType helper #127

Closed kotarella1110 closed 4 years ago

kotarella1110 commented 4 years ago

Added isOfType helper. (resolve #87) I would like you to review :pray:

the-dr-lazy commented 4 years ago

You can extract types of given keys then in assert function just use Array.prototype.includes function to check the type of given action is available or not. Please check ofType function implementation for inspiration. https://github.com/thebrodmann/deox/blob/8b0bbcec09703f93eb4c89398b24d1a0a4117bc8/src/of-type.ts#L42-L48

kotarella1110 commented 4 years ago

I imploved ideal dts test! https://github.com/thebrodmann/deox/pull/127/commits/4578a7a9d83f15fa92334db4b5f31fc49cc74418 fixed https://github.com/thebrodmann/deox/pull/127#discussion_r354477498, https://github.com/thebrodmann/deox/pull/127#discussion_r354478165 I want you to review again when you have time 🙏

kotarella1110 commented 4 years ago

I am really grad to contribute to this wonderful library. I learned a lot from creating this PR and your review :green_heart: Thank you very much! I will fix the problems that you pointed out today or tomorrow!

the-dr-lazy commented 4 years ago

:tada: This issue has been resolved in version 3.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: