Closed kotarella1110 closed 4 years ago
Merging #133 into next will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## next #133 +/- ##
===================================
Coverage 100% 100%
===================================
Files 10 10
Lines 59 60 +1
Branches 12 12
===================================
+ Hits 59 60 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/of-type.ts | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update cc01d9d...d3f2f27. Read the comment docs.
I changed the ofType RxJS operator to use isOfType helper function too!
Let's do it in another PR.
I changed the ofType RxJS operator to use isOfType helper function too!
Let's do it in another PR.
OK! In anothor PR, the code is as follows.
export function ofType<
TSource extends AnyAction,
TKey extends string | AnyAction | ActionCreator<AnyAction>,
TSink extends TSource = ExtractAction<TKey, TSource>
>(keys: TKey | ReadonlyArray<TKey>) {
return filter<TSource, TSink>(isOfType(keys))
}
Also, May I fix the generics of isOfType
helper function to follow RxJS convention?
After this PR is merged, I willl change the ofType RxJS operator to use isOfType helper function 💚
Well done @kotarella1110.
:tada: This PR is included in version 3.2.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 3.2.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
I changed the
ofType
RxJS operator to useisOfType
helper function too! We can pass toofType
with array mix of action type, action, and action creator as follows.