search

the-dr-lazy / deox

Functional Type-safe Flux Standard Utilities
https://deox.js.org
MIT License
206 stars 12 forks source link

Explain or remove `resolve => x => resolve(x)` pattern #148

Closed MagnusBrzenk closed 4 years ago

MagnusBrzenk commented 4 years ago

I looked very briefly at this project. But as soon as I got to this unfamiliar pattern:

resolve => (count: number) =>
  resolve(count)

... I gave up. Either explain why this resolve pattern is needed here (and not just e.g. a payload), or simplify your library. Life is too short to guess the coder's motivations.

the-dr-lazy commented 4 years ago

Looks like this is duplicate of #122.