the-draupnir-project / Draupnir

A Matrix moderation bot
https://the-draupnir-project.github.io/draupnir-documentation/
70 stars 14 forks source link

Mitigation for accidental bans #410

Open Gnuxie opened 2 months ago

Gnuxie commented 2 months ago

Someone was accidentally banned on CME, which could have resulted them being banned automatically in a lot of rooms, whose mods might not be active or aware that the ban was removed due to a mistake.

There are two ways that i can think of right now to solve this:

  1. an explicit policy for when a user has been unbanned.
  2. a protection that checks room level bans against policies and notifies when there is a discrepancy
FSG-Cat commented 2 months ago

this can in theory be solved with a simple ammendment to https://github.com/matrix-org/matrix-spec-proposals/pull/3908 and then implemented via solving https://github.com/the-draupnir-project/Draupnir/issues/189 and that helps with solving https://github.com/the-draupnir-project/Draupnir/issues/219 to a full and satisfactory point.

The amendment to MSC3908 is to say that you dont look into the past revisions to check for past policies that target the subject of the expired policy to check if you are going to unwind the policy or not.

Since after all Expired policies are supposed to be treated as if they dont exist by reverting to the state you had before the policy. Only complicating factor is how to diffirentiate manual bans and i say that is solvable via just do a implementation level detail and say if ban source is other than self then dont touch it.