search

the-ethan-hunt / B.E.N.J.I.

B.E.N.J.I.- The Impossible Missions Force's digital assistant
MIT License
91 stars 94 forks source link

Make B.E.N.J.I. recognize positions of "stream" and "play" #83

Open rohanricky opened 6 years ago

rohanricky commented 6 years ago

Since youtube play feature is above download it is causing few bugs errors. For example, if I type download Coldplay Paradise, it contains play so it is playing the video. Similarily, Chainsmokers Bloodstream contains stream.

the-ethan-hunt commented 6 years ago

Nice spotting the bug, @rohanricky !

the-ethan-hunt commented 6 years ago

This issue is open for discussion: @aribalam , @kb-studios @Yatish04 . You all are open to discuss this issue

kaushal-py commented 6 years ago

As this can be a very broad issue, can we start off using NLP gradually, maybe using nltk? We can do basic tokenizing.

the-ethan-hunt commented 6 years ago

Good thinking @kb-studios ! But tokenizing requires a knowledge of NLP. But though won't fix for sometime, this is a good issue for discussion

Yatish04 commented 6 years ago

Yeah we have to use nlp at the end of the day.😀 So as of now it's limited

rohanricky commented 6 years ago

For now we can reverse it's order to get it working or since we are using download and play at starting only we can use .startwith() for this also. This is just a quick fix eventually we can work on nlp.

the-ethan-hunt commented 6 years ago

You are right @rohanricky in this sense. We can use that temporarily. You can work on this issue. but we are not closing it