search

the-ethan-hunt / first-timers-guide

A collection of guides for and by first-timers
MIT License
179 stars 199 forks source link

Added a new file Git and PR.md which explains how a beginner can send a PR on gitHUB #244

Closed kasheravaibhav14 closed 4 years ago

kasheravaibhav14 commented 4 years ago

NOTE:

Did you read the instructions in the README?

Y

Have you read the instructions in CONTRIBUTING?

Y

I have taken inspiration from my senior MANAN GOEL and have written this article on how as a beginner one can send a PR on github.

kasheravaibhav14 commented 4 years ago

No changes have been made to pull_request_template.md That has been written by mistake. Please overlook it

kasheravaibhav14 commented 4 years ago

Thanks! I'll merge the changes asap

On Sun, Oct 13, 2019 at 9:54 PM Dhruv Apte notifications@github.com wrote:

@the-ethan-hunt requested changes on this pull request.

In guides/Version_Control/Git and PR.md https://github.com/the-ethan-hunt/first-timers-guide/pull/244#discussion_r334284846 :

@@ -0,0 +1,14 @@ +Git has been one of the most famous Version control application in this century. +It works like taking screenshot of project which you are working on and storing it like every version control. +Git works on local machine and remote servers like github. +we follow a particular protocol in using git +Pull requests

  • (Basic)(working only in master branch)
    1. It is a kind of request you make to the owner of the project when you have contributed to his/her project and want that contribution to be shown.

Your explanation is really great but could you Git SLOC (Lines of code) for operations pulling a PR and committing it? Include the SLOC and this PR is good to be merged.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/the-ethan-hunt/first-timers-guide/pull/244?email_source=notifications&email_token=AMKXOVQ4OHCOPIQGXMMLN73QONDT5A5CNFSM4I53OGUKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHY32LA#pullrequestreview-301055276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMKXOVSI5WENYKKDDANIPV3QONDT5ANCNFSM4I53OGUA .

kasheravaibhav14 commented 4 years ago

I mistakenly deleted the previous PR, but I added a new one so please can you check it. Thanks for the patience!

On Sun, Oct 13, 2019 at 11:37 PM Vaibhav Kashera kasheravaibhav14@gmail.com wrote:

Thanks! I'll merge the changes asap

On Sun, Oct 13, 2019 at 9:54 PM Dhruv Apte notifications@github.com wrote:

@the-ethan-hunt requested changes on this pull request.

In guides/Version_Control/Git and PR.md https://github.com/the-ethan-hunt/first-timers-guide/pull/244#discussion_r334284846 :

@@ -0,0 +1,14 @@ +Git has been one of the most famous Version control application in this century. +It works like taking screenshot of project which you are working on and storing it like every version control. +Git works on local machine and remote servers like github. +we follow a particular protocol in using git +Pull requests

  • (Basic)(working only in master branch)
    1. It is a kind of request you make to the owner of the project when you have contributed to his/her project and want that contribution to be shown.

Your explanation is really great but could you Git SLOC (Lines of code) for operations pulling a PR and committing it? Include the SLOC and this PR is good to be merged.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/the-ethan-hunt/first-timers-guide/pull/244?email_source=notifications&email_token=AMKXOVQ4OHCOPIQGXMMLN73QONDT5A5CNFSM4I53OGUKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHY32LA#pullrequestreview-301055276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMKXOVSI5WENYKKDDANIPV3QONDT5ANCNFSM4I53OGUA .