Closed justlevine closed 1 year ago
Hi @justlevine,
We'll take a look at this as soon as we can. Thanks for your help on it!
Agreed, that's why I made this a separate workflow. It was meant to be temporary.
Agree, that's why I made this a separate workflow. It was meant to be temporary.
@bordoni @justlevine Closed because CI secret are unreadable from PR across forks.
This PR adds partial support for Virtual Events extension.
What it includes:
The meta fields from
src/Tribe/Models/Event.php
:isVirtual
virtualUrl
virtualEmbedVideo
virtualLinkedButton
virtualLinkedButtonText
virtualShowEmbedAt
virtualShowEmbedTo
virtualShowLeadUp
virtualIsLinkable
virtualIsImmediate
virtualShouldShowEmbed
virtualShouldShowLink
What's not included.
src/Tribe/Meetings/Zoom/Event_Meta.php
). I don't have access to the Zoom API, so I can't reasonably test it. If you want me to add them in blind, I'm happy to.Feedback please.
I chose to stick to the naming that TEC gave its meta fields, even though their naming system isn't self-documenting (e.g.
virtualEmbedVideo
andvirtualLinkedButton
are bool, but differ in purpose tovirtualShouldShowEmbed
andvirtualShouldShowLink
). Ideally, Id change/merge some of these fields to make them easier for the user. Something likevirtualDisplayType: ("embed" | "link")
andvirtualShouldShow
. Thoughts?