the-events-calendar / ql-events

The Events Calendar binding to WPGraphQL
15 stars 7 forks source link

Add (partial) support for Virtual Events extension #20

Closed justlevine closed 1 year ago

justlevine commented 3 years ago

This PR adds partial support for Virtual Events extension.

What it includes:

The meta fields from src/Tribe/Models/Event.php: isVirtual virtualUrl virtualEmbedVideo virtualLinkedButton virtualLinkedButtonText virtualShowEmbedAt virtualShowEmbedTo virtualShowLeadUp virtualIsLinkable virtualIsImmediate virtualShouldShowEmbed virtualShouldShowLink

What's not included.

Feedback please.

I chose to stick to the naming that TEC gave its meta fields, even though their naming system isn't self-documenting (e.g. virtualEmbedVideo and virtualLinkedButton are bool, but differ in purpose to virtualShouldShowEmbed and virtualShouldShowLink). Ideally, Id change/merge some of these fields to make them easier for the user. Something like virtualDisplayType: ("embed" | "link") and virtualShouldShow. Thoughts?

craigwilcox commented 3 years ago

Hi @justlevine,

We'll take a look at this as soon as we can. Thanks for your help on it!

kidunot89 commented 1 year ago

Agreed, that's why I made this a separate workflow. It was meant to be temporary.

kidunot89 commented 1 year ago

Agree, that's why I made this a separate workflow. It was meant to be temporary.

kidunot89 commented 1 year ago

@bordoni @justlevine Closed because CI secret are unreadable from PR across forks.