the-events-calendar / ql-events

The Events Calendar binding to WPGraphQL
15 stars 7 forks source link

Unexpected Results with Where Queries When Hiding Subsequent Recurrences #65

Open brittonwalker opened 7 months ago

brittonwalker commented 7 months ago

I've encountered an issue where none of my where queries return the expected results when I set the option to hide subsequent recurrences of events to true. This problem seems to specifically arise in the context of using where arguments in queries, and I have identified a couple of insights that might help diagnose the issue.

Expected Behavior

The expectation is that where queries should return consistent and accurate results, regardless of the hiding subsequent recurrences setting.

Current Behavior

When hiding subsequent recurrences is enabled, where queries yield unexpected results, suggesting that this specific setting might be interfering with how queries are processed or resolved.

Main Issue with Hiding Subsequent Recurrences:

When the option to hide subsequent recurrences is enabled (set to true), my where queries do not work as expected. This issue does not occur when hiding subsequent recurrences is false. Reproduction Steps Here are example queries demonstrating the issue:

Query with Hiding Subsequent Recurrences set to False: Screen Shot 2024-02-18 at 6 12 19 PM

Query with Hiding Subsequent Recurrences set to True: Screen Shot 2024-02-18 at 6 14 05 PM

There is a also a typo in class-event-connection-resolver.php:

I noticed a typo in the file class-event-connection-resolver.php on line 365, where isset checks for hide_subsequenet_recurrences instead of hide_subsequent_recurrences. Here's the link to the specific line: Link to code. Correcting this typo, unfortunately, does not resolve the main issue but might still be relevant for code integrity and functionality.

Environment

Event Calendar Version: 6.3.2 Event Calendar Pro Version: 6.3.1 QL Events Plugin Version: 0.3.1