search

the-events-calendar / the-events-calendar-category-colors

Plugin add-on for The Events Calendar to colorize categories
https://wordpress.org/plugins/the-events-calendar-category-colors
44 stars 19 forks source link

Simplify setup (avoid multiple unnecessary setup calls). #147

Closed barryhughes closed 1 year ago

barryhughes commented 1 year ago

Simplifies the legend superpower setup process: we now only call setup() once (and rely on the afterSetup.tribeEvents event for this). Screenshot verifying superpower functionality after this change:

leg-superpowers-func-test

Note the absence of the 'double dim' problem described in the linked issue.

Closes #146.

afragen commented 1 year ago

@barryhughes I don't know when it happened, but could you test the latest develop branch. Superpowers isn't working for me.

afragen commented 1 year ago

If the user selects a category that doesn't have any items the non-selected legend menu items do not appear to dim and none of the events dim.

I would expect that the non-selected menu items dim and all events dim.

barryhughes commented 1 year ago

Yep, apologies ... I misunderstood how things were intended to work in this scenario. I've submitted a fix 😬