search

the-events-calendar / the-events-calendar-category-colors

Plugin add-on for The Events Calendar to colorize categories
https://wordpress.org/plugins/the-events-calendar-category-colors
44 stars 19 forks source link

Fix event/legend dimming. #148

Closed barryhughes closed 1 year ago

barryhughes commented 1 year ago

Relating to the conversation over here: even if the selected category does not have items on the page, other events and legend entries should still be dimmed.

unusued-cat-dimming

☝🏼 In the above screencast, no items belonging to category Unused are present on the page, but we still get the dimming effect.

afragen commented 1 year ago

Can you test https://tribe.thefragens.net ? All the events are of a single category. Clicking one of the legend items having no associated events doesn't seem to do anything.

barryhughes commented 1 year ago

So it seems to work for me ... though please let me know if I'm missing the obvious 😅

test-fragens-01

But, the 'double dimming' problem (when the page is first loaded) is still present here—I think because there are two event views embedded in this page. Unfortunately, I don't have access to Events Calendar PRO any more and couldn't test multiple views, though I think this problem may have existed previously, too?

barryhughes commented 1 year ago

...To clarify, regarding 'double dimming' this shows what I'm seeing and am referring to:

double-view-double-dim

You can see it if you hard refresh the page. Though I feel fairly confident—as confident as I can be without ECP to test with, anyway—that we'd see the same (or possibly even something more like a 'triple dimming') if you rolled back the version to 7.2.0, and if so it could probably be dealt with separately.

afragen commented 1 year ago

It must've been a browser cache issue for me. Now working and I do see the double dim.

barryhughes commented 1 year ago

Yep ... the double dim is interesting because it's a side effect from another problem (at least, I think it should be regarded as a problem). Using your test site:

Whereas, I think the preferred behaviour would be to treat these as separate instances. I could log a bug and hopefully follow-up with a further change for that. Again, I'm pretty sure this is not new and was not introduced via this recent train of PRs, though I can't actually verify.

afragen commented 1 year ago

I'm still testing as I'm seeing some odd behavior.

Neither of these are present in v2.7.0

barryhughes commented 1 year ago

Yeah, I did see some weirdness (on your test site, though not locally). How is your homepage composed—is it basically two shortcode blocks, each containing [tribe_events]? I also noticed month view actually appears to be list view, though I again can't replicate the same thing locally 🤔

I should add that, so far, my local testing has only involved TECCC + TEC, and not any other addons.

afragen commented 1 year ago

Yes, a post on home page is 2 shortcode blocks. [tribe_events view="month"] and [tribe_events view="list"].

The calendar should be month view but there are no current events and for some reason displays as list view, even with the month selected. Perhaps this is some sort of edge case bug when there are no "current" events. 🤔

Most of the plugins are mine. 😉

Environment

barryhughes commented 1 year ago

I've submitted another PR (!) ... it greatly improves the behavior when 2 or more event views are present on the same page.