Testing legend-superpowers

[afragen]

@barryhughes on my test site, https://tribe.thefragens.net, I am having issues on mobile. Doesn't seem to be able to change view or select legend menu. 🧐

Almost as if JS not loading on mobile.

[barryhughes]

Something is definitely afoot, though I'm not sure what. On your site (check the exposed and weirdly spaced span tags):

Yet locally I don't see the same when I drop into mobile view:

Will need to play and experiment a little 🕵🏼

[afragen]

I'm not seeing that either on laptop or iPhone.

[barryhughes]

OK, that's odd ... now I consistently see the < span > ... < / span > on all devices (when looking at tribe.thefragens.net, I mean) but I was sure when I last looked it was only on mobile.

[barryhughes]

Wait, I think I see what's happening (and the reason I didn't see this locally is simply because I was still testing with my branch). Here's the recent commit history for the develop branch:

• Dev bump https://github.com/afragen/the-events-calendar-category-colors/commit/59acaa852deaf2910ea8e7548fe6bd68e48274de
• wpcs https://github.com/afragen/the-events-calendar-category-colors/commit/468cffa69602a99a46d092a7e102b69f16cac6a0
• Merge PR #149 https://github.com/afragen/the-events-calendar-category-colors/commit/4e4ba52e677a20221ce4ffbdc9a5b8c80f660936

Looking at the second-from-last commit ("wpcs"), we can see formatting fixes, but also changes like this one:

- const replacementText = `<span>${linkTitle}</span>`;
+ const replacementText = ` < span > ${linkTitle} < / span > `;

That might explain some of the weirdness.

[afragen]

I see it too now. Makes me wonder why WPCS for JS would do that. Let me fix it.

[afragen]

These are the "errors" phpcs is detecting.

137 | ERROR   | [x] Expected 1 space before "<"; 0 found (WordPress.WhiteSpace.OperatorSpacing.NoSpaceBefore)
 137 | ERROR   | [x] Expected 1 space after "<"; 0 found (WordPress.WhiteSpace.OperatorSpacing.NoSpaceAfter)
 137 | ERROR   | [x] Expected 1 space before ">"; 0 found (WordPress.WhiteSpace.OperatorSpacing.NoSpaceBefore)
 137 | ERROR   | [x] Expected 1 space after ">"; 0 found (WordPress.WhiteSpace.OperatorSpacing.NoSpaceAfter)
 137 | ERROR   | [x] Expected 1 space before "<"; 0 found (WordPress.WhiteSpace.OperatorSpacing.NoSpaceBefore)
 137 | ERROR   | [x] Expected 1 space after "<"; 0 found (WordPress.WhiteSpace.OperatorSpacing.NoSpaceAfter)
 137 | ERROR   | [x] Expected 1 space before "/"; 0 found (WordPress.WhiteSpace.OperatorSpacing.NoSpaceBefore)
 137 | ERROR   | [x] Expected 1 space after "/"; 0 found (WordPress.WhiteSpace.OperatorSpacing.NoSpaceAfter)
 137 | ERROR   | [x] Expected 1 space before ">"; 0 found (WordPress.WhiteSpace.OperatorSpacing.NoSpaceBefore)
 137 | ERROR   | [x] Expected 1 space after ">"; 0 found (WordPress.WhiteSpace.OperatorSpacing.NoSpaceAfter)

[afragen]

My guess is it has to do with being inside of backticks.

[barryhughes]

Yep, those rules probably make sense when applied outside of a string, in a comparison or when doing arithmetic. It would seem like a bug for them to be applied inside a string and outside of interpolated fragments.

That is, it might make sense to change:

const myString = `<p>Hello ${ age<15 ? 'kid' : 'shipmate' }</p>`

Into:

const myString = `<p>Hello ${ age < 15 ? 'kid' : 'shipmate' }</p>`

But not:

const myString = ` < p > Hello ${ age < 15 ? 'kid' : 'shipmate' } < /p > `

[barryhughes]

Interesting: https://github.com/squizlabs/PHP_CodeSniffer/issues/2594.

Perhaps it is better to switch away to eslint or similar (for JS)?

[afragen]

I updated phpcs.xml to not parse *.js

[barryhughes]

Let me know if you continue to see any odd behavior: I poked around and things are looking stable again when I test locally with the latest develop branch code.

(Though I do still see some weirdness on your test site, but I believe that is unrelated to these changes ... for instance, trying to switch to month view doesn't work, and I see the HTML response is 403 Forbidden.)

[afragen]

Seems to be working in latest testing. I'll see about merging and release next week.