search

the-events-calendar / the-events-calendar-category-colors

Plugin add-on for The Events Calendar to colorize categories
https://wordpress.org/plugins/the-events-calendar-category-colors
45 stars 19 forks source link

Update for php8 errors when passing null as parameter #159

Closed afragen closed 4 months ago

afragen commented 4 months ago

This should fix #156 and hopefully fix #157.

Replaces #158 by starting from a different branch on my end. Sorry.

afragen commented 4 months ago

Keeping the GitHub Plugin URI to afragen/the-events-calendar-category-colors allows for updating of test branches via Git Updater while the master branch will always update from dot org.

afragen commented 4 months ago

@Camwyn I didn't test that just converted from null checks. Seems like a good idea.

bordoni commented 4 months ago

I will merge as is since it fixes the problem reported and ship as version 7.3.1 tomorrow AM is that ok?

afragen commented 4 months ago

Sounds great. Checking the array_filter to remove empty values might actually cause issues if the code expects something to be present even if empty.

bordoni commented 4 months ago

@afragen it should be ready for release, I did all the version bumps on develop can you double check? (same to you @Camwyn)

I am out for a bit this morning, lets ship around 12 EST

afragen commented 4 months ago

It all looks good.

You will need to change the Settings > Secrets > Actions for the GitHub Actions to work. This includes the deploy action to SVN.