search

the-events-calendar / the-events-calendar-category-colors

Plugin add-on for The Events Calendar to colorize categories
https://wordpress.org/plugins/the-events-calendar-category-colors
45 stars 19 forks source link

Week view: CSS conflict #49

Closed barryhughes closed 10 years ago

barryhughes commented 10 years ago

I'm seeing the following in weekview.

legend-css-week-view

Seems to relate to this CSS that we're outputting:

.tribe-grid-body div[id*="tribe-events-event-"] .hentry.vevent,
.tribe-grid-body div[id*="tribe-events-event-"] .hentry.vevent:hover,
.tribe-grid-allday div[id*="tribe-events-event-"].hentry.vevent div { 
    background-color: #fff; 
}
barryhughes commented 10 years ago

Hmm.

Not sure what the answer is here, but it seems if we don't want to 'wipe' uncategorized events (by setting the background to white, given the foreground text is also white by default) we might need to dispose of Tribe_Events_Category_Colors_Extras::fix_default_week_background(); and come up with a JS-based solution.

Unless there's a clever CSS trick I'm missing.

What do you think @afragen?

afragen commented 10 years ago

Do you have that site up somewhere I can look at it? I've got http://tribe.thefragens.net as my online dev site.

I wonder what would happen if we kept the background white and changed the opacity?

I'm heading of to WordCamp OC in the morning so I won't have time to play with this until next week.

barryhughes commented 10 years ago

Do you have that site up somewhere I can look at it?

Nope, was working locally. No problem though - you basically just need a few uncategorized events to see the issue.

I'm going to modify the CSS so that we only target categorized events and anything else is left alone (and will be styled to Tribe defaults - so blueish in colour).

barryhughes commented 10 years ago

Let me know what you think of 9334bef29a29605d1900aa11c3b281f9c252cb4a when you get a chance ... not sure if the final effect isn't a bit jarring when week view has a mix of categorized and uncategorized events.

afragen commented 10 years ago

I think this looks and works fine. Uncategorized events have the default appearance. See http://tribe.thefragens.net/events/week/2014-06-08 as example.