the-fab-cube / flesh-and-blood-cards

Open source JSON/CSV representations of the cards for the Flesh and Blood TCG
105 stars 35 forks source link

Some of the card image URLS have having trouble. #409

Closed miclede closed 5 months ago

miclede commented 5 months ago

Aegis, Archangel of Protection: image

Pretty good ratio of winners - of the roughly 10k images only roughly 3% of them are showing issues. image

Here is what my downloader / parser has listed as broken: (Name_Color) Aegis, Archangel of Protection_None Avalon, Archangel of Rebirth_None Azvolai_None Bellona, Archangel of War_None Blasmophet, Levia Consumed_None Cromai_None Dishonor_Blue Dominia_None Dracona Optimai_None Fractal Replication_Red Hummingbird, Adventurer's Call_None Kyloria_None Metis, Archangel of Tenacity_None Miragai_None Nekria_None Nitro Mechanoid_None Ouvia_None Sekem, Archangel of Ravages_None Suraya, Archangel of Erudition_None Suraya, Archangel of Knowledge_None Taylor_None Teklovossen, the Mechropotent_None Themai_None Themis, Archangel of Judgment_None Timekeeper's Whim_Blue Timekeeper's Whim_Red Timekeeper's Whim_Yellow Tomeltai_None Victoria, Archangel of Triumph_None Vynserakai_None Yendurai_None Yorick, Weaver of Tales_None

miclede commented 5 months ago

I can talk about this on discord too.

miclede commented 5 months ago

old urls: https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD007BACK.png https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD007BACKV2.png

new working urls: https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD007_BACK.png https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD007_BACK_V2.png

2nd naming convention: https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR009ABack.png https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR009BBack.png to -> https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR009_A_Back.png https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR009_B_Back.png

I'm going to follow up with the full list in another comment.

miclede commented 5 months ago

Aegis, Archangel of Protection_None https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD007_BACK.png https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD007_BACK_V2.png

Avalon, Archangel of Rebirth_None https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD009_BACK.png https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD009_BACK_V2.png

Azvolai_None https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR009_A_Back.png https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR009_B_Back.png

Bellona, Archangel of War https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD012_BACK.png https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD012_BACK_V2.png

Blasmophet, Levia Consumed_None https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD164_BACK.png https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD164_BACK_V2.png

Cromai_None https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR010_A_Back.png https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR010_B_Back.png

Dishonor_Blue This link is just missing, I don't know where this card was being stored, but other cards with similar URLs still work. i.e: Infect_Blue: https://dhhim4ltzu1pj.cloudfront.net/media/images/OUT026.width-450.png works Dishonor_Blue: https://dhhim4ltzu1pj.cloudfront.net/media/images/OUT051.width-450.png 404 works under: https://dhhim4ltzu1pj.cloudfront.net/media/images/OUT051_tyYCr6g.width-450.png (Is the dhhim4ltzu1pj.cloudfront.net -> fabtcg.com?) I converted https://dhhim4ltzu1pj.cloudfront.net/media/images/OUT051_tyYCr6g.width-450.format-webp.webp from fabtcg to the above working url, seems like the gallery on there is all webp format.. where did these original png links come from?

Dominia_None https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR008_A_Back.png https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR008_B_Back.png

Dracona Optimai_None https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR006_A_Back.png https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR006_B_Back.png

Fractal Replication_Red (Both Image URLs) https://storage.googleapis.com/fabmaster/media/images/EVR138_Fractal_Replication.width-10000.png

Hummingbird, Adventurer's Call_None https://storage.googleapis.com/fabmaster/cardfaces/promos/FAB094_A.png https://storage.googleapis.com/fabmaster/cardfaces/promos/FAB094_B.png

Kyloria_None https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR011_A_Back.png https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR011_B_Back.png

Metis, Archangel of Tenacity_None https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD010_BACK.png https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD010_BACK_V2.png

Miragai_None https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR012_A_Back.png https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR012_B_Back.png

Nekria_None https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR013_A_Back.png https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR013_B_Back.png

Nitro Mechanoid_None https://storage.googleapis.com/fabmaster/cardfaces/2022-DYN/EN/DYN092_Back.png https://storage.googleapis.com/fabmaster/cardfaces/2022-DYN/EN/DYN092_Back.png https://storage.googleapis.com/fabmaster/cardfaces/2022-DYN/EN/DYN092_Marvel_Back.png

Ouvia_None https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR014_A_Back.png https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR014_B_Back.png

Sekem, Archangel of Ravages_None https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD008_BACK.png https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD008_BACK_V2.png

Suraya, Archangel of Erudition_None https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD005_BACK.png https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD005_BACK_V2.png

Suraya, Archangel of Knowledge_None (Both links) https://storage.googleapis.com/fabmaster/cardfaces/2022-DYN/EN/DYN212_BACK.png

Taylor_None https://storage.googleapis.com/fabmaster/cardfaces/promos/LSS003_A.png https://storage.googleapis.com/fabmaster/cardfaces/promos/LSS003_B.png

Teklovossen, the Mechropotent_None https://storage.googleapis.com/fabmaster/cardfaces/2023-EVO/EN/EVO010_BACK.png https://storage.googleapis.com/fabmaster/cardfaces/2023-EVO/EN/EVO010_BACK_V2.png

Themai_None https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR015_A_Back.png https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR015_B_Back.png

Themis, Archangel of Judgment_None https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD006_BACK.png https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD006_BACK_V2.png

Timekeeper's Whim_Blue (Both links) https://storage.googleapis.com/fabmaster/media/images/MON136_Timekeepers_Whim.width-10000.png

Timekeeper's Whim_Red (Both links) https://storage.googleapis.com/fabmaster/media/images/MON134_Timekeepers_Whim.width-10000.png

Timekeeper's Whim_Yellow (Both links) https://storage.googleapis.com/fabmaster/media/images/MON135_Timekeepers_Whim.width-10000.png

Tomeltai_None https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR007_A_Back.png https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR007_B_Back.png

Victoria, Archangel of Triumph_None https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD011_BACK.png https://storage.googleapis.com/fabmaster/cardfaces/2023-DTD/EN/DTD011_BACK_V2.png

Vynserakai_None https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR016_A_Back.png https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR016_B_Back.png

Yendurai_None https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR017_A_Back.png https://storage.googleapis.com/fabmaster/cardfaces/2022-UPR/UPR017_A_Back.png

Yorick, Weaver of Tales_None https://storage.googleapis.com/fabmaster/cardfaces/promos/LSS004_A.png https://storage.googleapis.com/fabmaster/cardfaces/promos/LSS004_B.png

miclede commented 5 months ago

Issue was on my side, seems like the card.json file I downloaded just came with no "_" characters in it, I re-got the latest and everything works.

miclede commented 5 months ago

Closing issue.