the-fab-cube / flesh-and-blood-cards

Open source JSON/CSV representations of the cards for the Flesh and Blood TCG
99 stars 34 forks source link

feat: add missing hp1 blitz decks #420

Closed Eik-S closed 2 months ago

Eik-S commented 3 months ago

I added some missing blitz decks released with History Pack 1 - Black Label. I would also add the corresponding cards but wanted to ask if you have any suggestions on how to speed up the process of adding hundreds of cards.

If there is no helper script yet, i could try to write one using the new api provided by LSS.

e.g. https://cards.fabtcg.com/api/search/v1/cards/?set_code=1HV returns all cards from the Viserai blitz deck

luceleaftea commented 3 months ago

This is the first I'm hearing that the official API was released, this is amazing news!

I had been waiting on them to release the API to automate the process of adding the missing non-English cards, so a helper script would be incredibly welcome! Feel free to do that in a separate PR if you have time, and I'll try to find some time soon to reviewing this PR. Otherwise if you don't have time coming up for a helper script I can start looking into their API.

Thank you for the PR!

luceleaftea commented 3 months ago

Update: checked in with a contact at LSS and they'd prefer if we don't hit that API just yet. Apparently that is not an API intended for public consumption yet, and as such the data models will very likely change so developing against it will not be reliable. I'll investigate if there are any ways we can automate data entry without that API in the meantime!