search

the-fab-cube / flesh-and-blood-cards

Open source JSON/CSV representations of the cards for the Flesh and Blood TCG
105 stars 35 forks source link

Update MON images to use higher resolution #71

Open luceleaftea opened 2 years ago

luceleaftea commented 2 years ago

Pull higher resolution images from https://fabtcg.com/documents/157/fabtcg_datasheet-21.xlsx

CaitM8Codes commented 2 years ago

Hey, would love to help with this! Forgive my potential ignorance, but could you clarify what needs to be done please? I compared a few of the images from the above xlsx with their corresponding ones on the site and they look identical (besides the different html file src obviously). Did the image src's need replacing? I'm a total newbie attempting to participate in Hacktoberfest and this seems like a cool way to do it, cheers :)

luceleaftea commented 2 years ago

I can definitely clarify!

So LSS (the devs of Flesh and Blood) usually update their card galleries on their website more frequently than the Excel document I linked, so images for this data set are usually initially pulled from the card galleries. However, the card images on the card galleries are a smaller resolution than the images in the Excel document. So, whenever LSS updates the Excel document, the data set has to be be updated with the full resolution image links. Here's an example of the size difference:

Gallery version - https://storage.googleapis.com/fabmaster/media/images/MON000.width-450.png Excel version - https://storage.googleapis.com/fabmaster/cardfaces/2021-MON/MON000.png

So for this task, all of the cards from the Monarch set (both 1st edition and unlimited edition) need to be updated! If you don't have time to do all the cards, no worries, feel free to just do a chunk and open a PR, and I can review it, merge it, and then update the task with what still needs to be done.

Thanks for helping out!!