search

the-grey-group / datalab

datalab is a place to store experimental data and the connections between them.
https://the-datalab.readthedocs.io/en/latest
MIT License
37 stars 15 forks source link

Fix StyledInput component (v2) #751

Closed jdbocarsly closed 1 month ago

jdbocarsly commented 1 month ago

Recent changes to StyledInput in https://github.com/the-grey-group/datalab/pull/706 inadvertently broke the display on the StartingMaterialInformation page by removing the bootstrap form-control class. This PR reverts this change so that form-control-plaintext is automatically set on readonly instances of StyledInput, and form-control is set on non-readonly instances.

However, this behavior can now be overwritten by directly providing one of these two classes to the StyledInput component, e.g. :

<StyledInput readonly class="form-control">

This PR replaces #735.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.24%. Comparing base (cace4f8) to head (02b528a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #751 +/- ## ======================================= Coverage 67.24% 67.24% ======================================= Files 62 62 Lines 3749 3749 ======================================= Hits 2521 2521 Misses 1228 1228 ```
cypress[bot] commented 1 month ago

Passing run #1849 ↗︎

0 40 0 0 Flakiness 0

Details:

Merge 02b528a8a79e6a358b38e330e3a39cb4f9a07409 into cace4f8518f4fdb3f9824d6554dd...
Project: datalab Commit: 564c123981 ℹ️
Status: Passed Duration: 02:08 💡
Started: May 31, 2024 4:00 AM Ended: May 31, 2024 4:03 AM

Review all test suite changes for PR #751 ↗︎