search

the-grey-group / datalab

datalab is a place to store experimental data and the connections between them.
https://the-datalab.readthedocs.io/en/latest
MIT License
37 stars 15 forks source link

Remove GET-out of route permissions #754

Closed ml-evs closed 1 month ago

ml-evs commented 1 month ago

Let's default to being stricter on permissions, rather than coding in special help for the public deployment. This PR locks down the inventory and equipment routes to active accounts only. This will eventually be fixed by the new permissions model #675.

cypress[bot] commented 1 month ago

Passing run #1877 ↗︎

0 40 0 0 Flakiness 0

Details:

Merge 41b07684fb07366afb42b1d8c6d5c90f38854a5e into b5618f9433473e927da5d22b0eb9...
Project: datalab Commit: 89b7579919 ℹ️
Status: Passed Duration: 01:59 💡
Started: May 31, 2024 5:33 PM Ended: May 31, 2024 5:35 PM

Review all test suite changes for PR #754 ↗︎

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.15%. Comparing base (b5618f9) to head (41b0768).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #754 +/- ## ======================================= Coverage 67.15% 67.15% ======================================= Files 62 62 Lines 3785 3785 ======================================= Hits 2542 2542 Misses 1243 1243 ``` | [Files](https://app.codecov.io/gh/the-grey-group/datalab/pull/754?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=the-grey-group) | Coverage Δ | | |---|---|---| | [pydatalab/pydatalab/permissions.py](https://app.codecov.io/gh/the-grey-group/datalab/pull/754?src=pr&el=tree&filepath=pydatalab%2Fpydatalab%2Fpermissions.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=the-grey-group#diff-cHlkYXRhbGFiL3B5ZGF0YWxhYi9wZXJtaXNzaW9ucy5weQ==) | `83.72% <ø> (ø)` | |