the-grey-group / datalab

datalab is a place to store experimental data and the connections between them.
https://the-datalab.readthedocs.io/en/latest
MIT License
37 stars 15 forks source link

Follow new auth requirements in UI tables #771

Closed ml-evs closed 3 weeks ago

ml-evs commented 3 weeks ago

i.e., do not show an error message if the API responds with unauthorized, just return a blank table.

At some point #675 will have to address this properly, as right now there is no longer a concept of anonymous, public samples (this will need to be patched explicitly on the public deployment) but it should be easier to transition from strict to looesr auth rather than the reverse (now that we are spreading).

As a side note, I have now disabled testing mode by default on the dev container, as it is now much more straightforward to do user management locally.

Hopefully this is the final PR before releasing!

Closes #762

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.16%. Comparing base (c94a924) to head (ee97329).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #771 +/- ## ======================================= Coverage 67.16% 67.16% ======================================= Files 62 62 Lines 3828 3828 ======================================= Hits 2571 2571 Misses 1257 1257 ```
cypress[bot] commented 3 weeks ago

Passing run #1919 ↗︎

0 40 0 0 Flakiness 0

Details:

Merge ee973293f34d5ae5ba3746fc41edfaf31039415f into c94a9248883e216bd02ba6ff294b...
Project: datalab Commit: bc291c4d8b ℹ️
Status: Passed Duration: 02:10 💡
Started: Jun 6, 2024 8:11 PM Ended: Jun 6, 2024 8:14 PM

Review all test suite changes for PR #771 ↗︎