search

the-grid / apidocs

API documentation for The Grid
https://developer.thegrid.io
44 stars 9 forks source link

coverPrefs #6

Closed forresto closed 9 years ago

forresto commented 9 years ago

crop filter overlay

forresto commented 9 years ago

Need anything else for this @jonnor @bergie ?

jonnor commented 9 years ago

Tests?

forresto commented 9 years ago

Like what?

jonnor commented 9 years ago

Like one example of invalid data, and one of valid data in a examples/metadata.yaml file would do the trick. Following the pattern of the other example files.

forresto commented 9 years ago

examples/metadata.yaml doesn't exist. I added a good example to examples/contentblock.yml but don't understand what kind of invalid example would be helpful.

forresto commented 9 years ago

OK, added a fail.

Ready.

jonnor commented 9 years ago

Thanks. In an attempt to clarify: The purpose of invalid type tests is primarily to know what the limitations specified in schema is (correctly) applied. The purpose of valid type tests is primarily to ensure that the data we intend to accept is actually accepted and that we continue to accept it as schema evolves (not breaking compatibility).

forresto commented 9 years ago

Yeah. Was heartening to first make the expected fail fail, then pass.

jonnor commented 9 years ago

Mo points!! On Apr 28, 2015 7:52 PM, "Forrest Oliphant" notifications@github.com wrote:

Yeah. Was heartening to first make the expected fail fail, then pass.

— Reply to this email directly or view it on GitHub https://github.com/the-grid/apidocs/pull/6#issuecomment-97266775.