search

the-grid / rig

Responsive Image Generator
MIT License
6 stars 1 forks source link

Add rig.simple, for breaks on single element #2

Closed jonnor closed 9 years ago

jonnor commented 9 years ago

Fixes #1

jonnor commented 9 years ago

@paulyoung Perhaps it should be called rig.single instead, as that is the main simplification here?

paulyoung commented 9 years ago

This couples image size to breakpoint size which is something I was trying to avoid.

It makes sense to do that for a full-screen background image but in a lot of cases we're displaying an image at a fraction of the screen width.

paulyoung commented 9 years ago

At first glance I'm a bit confused as to how assigning something to rig.simple is working since rig is a function...

I was anticipating the need to change the API slightly - perhaps making a CoffeeScript class called Rig which can be instantiated for the existing behavior and have class methods for convenience.

paulyoung commented 9 years ago

Closing this in favor of 9571e0fe16f0936894a0dbfe93e5ee36030ee962.