renovate[bot] commented 5 months ago

This PR contains the following updates:

Package	Update	Change
jaegertracing/all-in-one	minor	`1.55` -> `1.56`

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

github-actions[bot] commented 5 months ago

🚨 Rust Panic Audit: 102 Potential Panic Points Detected 🚨

Crate: `federation_query_planner`

📊 Total Usages: 53

🔎 expect usages: 8
🔢 array_index usages: 10
🎁 unwrap usages: 32
🚨 panic usages: 3

Crate: common

📊 Total Usages: 11
🔢 array_index usages: 1
🎁 unwrap usages: 10

Crate: telemetry

📊 Total Usages: 9
🎁 unwrap usages: 4
🔢 array_index usages: 5

Crate: cloudflare_worker

📊 Total Usages: 8
🚨 panic usages: 1
🎁 unwrap usages: 5
🔎 expect usages: 2

Crate: engine

📊 Total Usages: 7
🔎 expect usages: 1
🎁 unwrap usages: 6

Crate: tracing

📊 Total Usages: 6
🎁 unwrap usages: 5
🔎 expect usages: 1

Crate: conductor

📊 Total Usages: 5
🚨 panic usages: 1
🔎 expect usages: 3
🎁 unwrap usages: 1

Crate: config

📊 Total Usages: 3
🎁 unwrap usages: 2
🚨 panic usages: 1

📌 Expected Annotations

Crate: `cloudflare_worker`

📊 Total Expected Usages: 4

expand details

1. Reason: "it panics only if the header name is not valid, and we know it is." - Code: `.unwrap()` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:20` 2. Reason: "it panics only if the URL source is not valid, and it's already validated before." - Code: `let url = req.url().unwrap();` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:23` 3. Reason: "it only panics if we are not running in a CF context, should be safe." - Code: `let cf_info = req.cf().unwrap();` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:27` 4. Reason: "unwraps only in special cases where "data:text" is used." - Code: `let http_host = url.host().unwrap().to_string();` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:36`

Crate: `conductor`

📊 Total Expected Usages: 2

expand details

1. Reason: "we need to exit the process, if the logger can't be correctly set." - Code: `let _guard = tracing::subscriber::set_default(subscriber);` - Location: `./bin/conductor/src/lib.rs:37` 2. Reason: "we need to exit the process, if the provided configuration file is incorrect." - Code: `panic!("Failed to initialize gateway: {:?}", e);` - Location: `./bin/conductor/src/lib.rs:76`

Crate: `config`

📊 Total Expected Usages: 9

expand details

1. Reason: "part of development docgen CLI" - Code: `.expect("Failed to serialize json schema for config file!");` - Location: `./libs/config/src/generate-json-schema.rs:50` 2. Reason: "part of development docgen CLI" - Code: `.expect("Failed to write the json schema to the file system!");` - Location: `./libs/config/src/generate-json-schema.rs:54` 3. Reason: "👇" - Code: `let raw_contents = read_to_string(file_path)` - Location: `./libs/config/src/lib.rs:815` 4. Reason: "👇" - Code: `panic!("Failed to interpolate config file, please resolve the above errors");` - Location: `./libs/config/src/lib.rs:847` 5. Reason: "👇" - Code: `parse_config_from_json(&config_string).expect("Failed to parse JSON config file")` - Location: `./libs/config/src/lib.rs:854` 6. Reason: "👇" - Code: `parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file")` - Location: `./libs/config/src/lib.rs:858` 7. Reason: "👇" - Code: `_ => panic!("Unsupported config file extension"),` - Location: `./libs/config/src/lib.rs:875` 8. Reason: "👇" - Code: `None => panic!("Config file has no extension"),` - Location: `./libs/config/src/lib.rs:878` 9. Reason: "statically defined regex pattern, we know it works ;)" - Code: `.unwrap();` - Location: `./libs/config/src/interpolate.rs:18`

Crate: `napi`

📊 Total Expected Usages: 1

expand details

1. Reason: "we need this" - Code: `panic!("Exited process!")` - Location: `./libs/napi/src/lib.rs:18`

Crate: `engine`

📊 Total Expected Usages: 2

expand details

1. Reason: "if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit" - Code: `Err(e) => panic!("failed to construct endpoint: {:?}", e),` - Location: `./libs/engine/src/gateway.rs:158` 2. Reason: "we can safely index here, it's inside a test with constant defined fixtures." - Code: `ConductorGateway::execute(request, &gw.routes[0].route_data).await` - Location: `./libs/engine/src/gateway.rs:190`

Crate: `common`

📊 Total Expected Usages: 1

expand details

1. Reason: "we're parsing a statically defined constant, we know it works ;)" - Code: `.unwrap()` - Location: `./libs/common/src/graphql.rs:31`

Crate: `vrl`

📊 Total Expected Usages: 2

expand details

1. Reason: "if the provided VRL code in the config file can't compile, we have to exit." - Code: `panic!("failed to compile vrl program");` - Location: `./plugins/vrl/src/plugin.rs:129` 2. Reason: "`states` is a non-user provided variable" - Code: `.expect("can't merge states when `states` is an empty vector!")` - Location: `./plugins/vrl/src/plugin.rs:146`

Crate: `jwt_auth`

📊 Total Expected Usages: 1

expand details

1. Reason: "if initiating an http client fails, then we have to exit." - Code: `let client = wasm_polyfills::create_http_client().build().unwrap();` - Location: `./plugins/jwt_auth/src/jwks_provider.rs:49`

github-actions[bot] commented 5 months ago

🐋 This PR was built and pushed to the following Docker images:

Docker Bake metadata

```json { "conductor": { "buildx.build.ref": "builder-6a03939d-31d0-4e1b-9ffa-63032fb2cf0e/builder-6a03939d-31d0-4e1b-9ffa-63032fb2cf0e0/elt6g4sra0p5pj7j1bvq9wsgc", "containerimage.config.digest": "sha256:847ede1c6595120f2bdb3d26d267bffffd8f82f9534302483c68124ec863cc17", "containerimage.descriptor": { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "digest": "sha256:5a755ef8a6eb4338c0d0d72f7dd1f69d609b1860962c114e8d99995c14780eea", "size": 902, "platform": { "architecture": "amd64", "os": "linux" } }, "containerimage.digest": "sha256:5a755ef8a6eb4338c0d0d72f7dd1f69d609b1860962c114e8d99995c14780eea", "image.name": "ghcr.io/the-guild-org/conductor/conductor:e07811183643cf67771501983a6e26da96715007" } } ```

github-actions[bot] commented 5 months ago

✅ Benchmark Results

     data_received..................: 13 MB   221 kB/s
     data_sent......................: 22 MB   363 kB/s
     http_req_blocked...............: min=732ns    avg=2.6µs    med=1.95µs   max=517.52µs p(95)=2.98µs   p(99)=10.81µs 
     http_req_connecting............: min=0s       avg=329ns    med=0s       max=375.76µs p(95)=0s       p(99)=0s      
     http_req_duration..............: min=311.11µs avg=404.38µs med=380.78µs max=19.25ms  p(95)=461.09µs p(99)=535.25µs
       { expected_response:true }...: min=311.11µs avg=404.38µs med=380.78µs max=19.25ms  p(95)=461.09µs p(99)=535.25µs
     ✓ { scenario:rps_1000 }........: min=311.11µs avg=404.38µs med=380.78µs max=19.25ms  p(95)=461.09µs p(99)=535.25µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 60001
     ✓ { scenario:rps_1000 }........: 0.00%   ✓ 0           ✗ 60001
     http_req_receiving.............: min=10.13µs  avg=25.74µs  med=25.34µs  max=1ms      p(95)=32.97µs  p(99)=40.15µs 
     http_req_sending...............: min=6.26µs   avg=14.96µs  med=13.54µs  max=1.93ms   p(95)=25.03µs  p(99)=34.14µs 
     http_req_tls_handshaking.......: min=0s       avg=0s       med=0s       max=0s       p(95)=0s       p(99)=0s      
     http_req_waiting...............: min=272.35µs avg=363.67µs med=340.35µs max=18.95ms  p(95)=420.18µs p(99)=489.22µs
     http_reqs......................: 60001   1000.006349/s
     ✓ { scenario:rps_1000 }........: 60001   1000.006349/s
     iteration_duration.............: min=382.08µs avg=492.08µs med=467.22µs max=19.52ms  p(95)=555.53µs p(99)=676.35µs
     iterations.....................: 60001   1000.006349/s
     ✓ { scenario:rps_1000 }........: 60001   1000.006349/s
     valid_graphql_response.........: 100.00% ✓ 60001       ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001       ✗ 0    
     valid_http_code................: 100.00% ✓ 60001       ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001       ✗ 0    
     vus............................: 1       min=0         max=13 
     vus_max........................: 200     min=200       max=200

the-guild-org / conductor

chore(deps): update jaegertracing/all-in-one docker tag to v1.56 #558

Configuration

🚨 Rust Panic Audit: 102 Potential Panic Points Detected 🚨

Crate: `federation_query_planner`

Crate: `common`

Crate: `telemetry`

Crate: `cloudflare_worker`

Crate: `engine`

Crate: `tracing`

Crate: `conductor`

Crate: `config`

📌 Expected Annotations

Crate: `cloudflare_worker`

Crate: `conductor`

Crate: `config`

Crate: `napi`

Crate: `engine`

Crate: `common`

Crate: `vrl`

Crate: `jwt_auth`

✅ Benchmark Results

the-guild-org / conductor

chore(deps): update jaegertracing/all-in-one docker tag to v1.56 #558

Configuration

🚨 Rust Panic Audit: 102 Potential Panic Points Detected 🚨

Crate: federation_query_planner

Crate: common

Crate: telemetry

Crate: cloudflare_worker

Crate: engine

Crate: tracing

Crate: conductor

Crate: config

📌 Expected Annotations

Crate: cloudflare_worker

Crate: conductor

Crate: config

Crate: napi

Crate: engine

Crate: common

Crate: vrl

Crate: jwt_auth

✅ Benchmark Results

Crate: `federation_query_planner`

Crate: `common`

Crate: `telemetry`

Crate: `cloudflare_worker`

Crate: `engine`

Crate: `tracing`

Crate: `conductor`

Crate: `config`

Crate: `cloudflare_worker`

Crate: `conductor`

Crate: `config`

Crate: `napi`

Crate: `engine`

Crate: `common`

Crate: `vrl`

Crate: `jwt_auth`