github-actions[bot]
commented
6 months ago 🚨 Rust Panic Audit: 102 Potential Panic Points Detected 🚨
Crate: federation_query_planner
📊 Total Usages: 53
-
🎁
unwrapusages: 32 -
🔢
array_indexusages: 10 -
🔎
expectusages: 8 -
🚨
panicusages: 3Crate:
common📊 Total Usages: 11
-
🎁
unwrapusages: 10 -
🔢
array_indexusages: 1Crate:
telemetry📊 Total Usages: 9
-
🎁
unwrapusages: 4 -
🔢
array_indexusages: 5Crate:
cloudflare_worker📊 Total Usages: 8
-
🎁
unwrapusages: 5 -
🔎
expectusages: 2 -
🚨
panicusages: 1Crate:
engine📊 Total Usages: 7
-
🎁
unwrapusages: 6 -
🔎
expectusages: 1Crate:
tracing📊 Total Usages: 6
-
🔎
expectusages: 1 -
🎁
unwrapusages: 5Crate:
conductor📊 Total Usages: 5
-
🎁
unwrapusages: 1 -
🚨
panicusages: 1 -
🔎
expectusages: 3Crate:
config📊 Total Usages: 3
-
🎁
unwrapusages: 2 -
🚨
panicusages: 1
📌 Expected Annotations
Crate: conductor
📊 Total Expected Usages: 2
expand details
1. Reason: "we need to exit the process, if the logger can't be correctly set." - Code: `let _guard = tracing::subscriber::set_default(subscriber);` - Location: `./bin/conductor/src/lib.rs:37` 2. Reason: "we need to exit the process, if the provided configuration file is incorrect." - Code: `panic!("Failed to initialize gateway: {:?}", e);` - Location: `./bin/conductor/src/lib.rs:76`Crate: vrl
📊 Total Expected Usages: 2
expand details
1. Reason: "if the provided VRL code in the config file can't compile, we have to exit." - Code: `panic!("failed to compile vrl program");` - Location: `./plugins/vrl/src/plugin.rs:129` 2. Reason: "`states` is a non-user provided variable" - Code: `.expect("can't merge states when `states` is an empty vector!")` - Location: `./plugins/vrl/src/plugin.rs:146`Crate: cloudflare_worker
📊 Total Expected Usages: 4
expand details
1. Reason: "it panics only if the header name is not valid, and we know it is." - Code: `.unwrap()` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:20` 2. Reason: "it panics only if the URL source is not valid, and it's already validated before." - Code: `let url = req.url().unwrap();` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:23` 3. Reason: "it only panics if we are not running in a CF context, should be safe." - Code: `let cf_info = req.cf().unwrap();` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:27` 4. Reason: "unwraps only in special cases where "data:text" is used." - Code: `let http_host = url.host().unwrap().to_string();` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:36`Crate: jwt_auth
📊 Total Expected Usages: 1
expand details
1. Reason: "if initiating an http client fails, then we have to exit." - Code: `let client = wasm_polyfills::create_http_client().build().unwrap();` - Location: `./plugins/jwt_auth/src/jwks_provider.rs:49`Crate: config
📊 Total Expected Usages: 9
expand details
1. Reason: "statically defined regex pattern, we know it works ;)" - Code: `.unwrap();` - Location: `./libs/config/src/interpolate.rs:18` 2. Reason: "part of development docgen CLI" - Code: `.expect("Failed to serialize json schema for config file!");` - Location: `./libs/config/src/generate-json-schema.rs:50` 3. Reason: "part of development docgen CLI" - Code: `.expect("Failed to write the json schema to the file system!");` - Location: `./libs/config/src/generate-json-schema.rs:54` 4. Reason: "👇" - Code: `let raw_contents = read_to_string(file_path)` - Location: `./libs/config/src/lib.rs:815` 5. Reason: "👇" - Code: `panic!("Failed to interpolate config file, please resolve the above errors");` - Location: `./libs/config/src/lib.rs:847` 6. Reason: "👇" - Code: `parse_config_from_json(&config_string).expect("Failed to parse JSON config file")` - Location: `./libs/config/src/lib.rs:854` 7. Reason: "👇" - Code: `parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file")` - Location: `./libs/config/src/lib.rs:858` 8. Reason: "👇" - Code: `_ => panic!("Unsupported config file extension"),` - Location: `./libs/config/src/lib.rs:875` 9. Reason: "👇" - Code: `None => panic!("Config file has no extension"),` - Location: `./libs/config/src/lib.rs:878`Crate: engine
📊 Total Expected Usages: 2
expand details
1. Reason: "if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit" - Code: `Err(e) => panic!("failed to construct endpoint: {:?}", e),` - Location: `./libs/engine/src/gateway.rs:158` 2. Reason: "we can safely index here, it's inside a test with constant defined fixtures." - Code: `ConductorGateway::execute(request, &gw.routes[0].route_data).await` - Location: `./libs/engine/src/gateway.rs:190`Crate: common
📊 Total Expected Usages: 1
expand details
1. Reason: "we're parsing a statically defined constant, we know it works ;)" - Code: `.unwrap()` - Location: `./libs/common/src/graphql.rs:31`Crate: napi
📊 Total Expected Usages: 1
This PR contains the following updates:
1.0.58->1.0.60Release Notes
dtolnay/thiserror (thiserror)
### [`v1.0.60`](https://togithub.com/dtolnay/thiserror/releases/tag/1.0.60) [Compare Source](https://togithub.com/dtolnay/thiserror/compare/1.0.59...1.0.60) - Resolve unexpected_cfgs warning ([#298](https://togithub.com/dtolnay/thiserror/issues/298)) ### [`v1.0.59`](https://togithub.com/dtolnay/thiserror/releases/tag/1.0.59) [Compare Source](https://togithub.com/dtolnay/thiserror/compare/1.0.58...1.0.59) - Unblock testing of rustc `debug-fmt-detail` option ([#297](https://togithub.com/dtolnay/thiserror/issues/297))Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.