github-actions[bot]
commented
4 months ago 🚨 Rust Panic Audit: 342 Potential Panic Points Detected 🚨
Crate: ``
📊 Total Usages: 240
-
🔢
array_indexusages: 32 -
🚨
panicusages: 7 -
🎁
unwrapusages: 164 -
🔎
expectusages: 37Crate:
federation_query_planner📊 Total Usages: 53
-
🎁
unwrapusages: 32 -
🚨
panicusages: 3 -
🔢
array_indexusages: 10 -
🔎
expectusages: 8Crate:
common📊 Total Usages: 11
-
🔢
array_indexusages: 1 -
🎁
unwrapusages: 10Crate:
telemetry📊 Total Usages: 9
-
🔢
array_indexusages: 5 -
🎁
unwrapusages: 4Crate:
cloudflare_worker📊 Total Usages: 8
-
🚨
panicusages: 1 -
🔎
expectusages: 2 -
🎁
unwrapusages: 5Crate:
engine📊 Total Usages: 7
-
🔎
expectusages: 1 -
🎁
unwrapusages: 6Crate:
tracing📊 Total Usages: 6
-
🔎
expectusages: 1 -
🎁
unwrapusages: 5Crate:
conductor📊 Total Usages: 5
-
🎁
unwrapusages: 1 -
🚨
panicusages: 1 -
🔎
expectusages: 3Crate:
config📊 Total Usages: 3
-
🚨
panicusages: 1 -
🎁
unwrapusages: 2
📌 Expected Annotations
Crate: vrl
📊 Total Expected Usages: 2
expand details
1. Reason: "if the provided VRL code in the config file can't compile, we have to exit." - Code: `panic!("failed to compile vrl program");` - Location: `./plugins/vrl/src/plugin.rs:129` 2. Reason: "`states` is a non-user provided variable" - Code: `.expect("can't merge states when `states` is an empty vector!")` - Location: `./plugins/vrl/src/plugin.rs:146`Crate: ``
📊 Total Expected Usages: 22
expand details
1. Reason: "part of development docgen CLI" - Code: `.expect("Failed to serialize json schema for config file!");` - Location: `./libs/config/src/generate-json-schema.rs:50` 2. Reason: "part of development docgen CLI" - Code: `.expect("Failed to write the json schema to the file system!");` - Location: `./libs/config/src/generate-json-schema.rs:54` 3. Reason: "statically defined regex pattern, we know it works ;)" - Code: `.unwrap();` - Location: `./libs/config/src/interpolate.rs:18` 4. Reason: "👇" - Code: `let raw_contents = read_to_string(file_path)` - Location: `./libs/config/src/lib.rs:815` 5. Reason: "👇" - Code: `panic!("Failed to interpolate config file, please resolve the above errors");` - Location: `./libs/config/src/lib.rs:847` 6. Reason: "👇" - Code: `parse_config_from_json(&config_string).expect("Failed to parse JSON config file")` - Location: `./libs/config/src/lib.rs:854` 7. Reason: "👇" - Code: `parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file")` - Location: `./libs/config/src/lib.rs:858` 8. Reason: "👇" - Code: `_ => panic!("Unsupported config file extension"),` - Location: `./libs/config/src/lib.rs:875` 9. Reason: "👇" - Code: `None => panic!("Config file has no extension"),` - Location: `./libs/config/src/lib.rs:878` 10. Reason: "we're parsing a statically defined constant, we know it works ;)" - Code: `.unwrap()` - Location: `./libs/common/src/graphql.rs:31` 11. Reason: "we need this" - Code: `panic!("Exited process!")` - Location: `./libs/napi/src/lib.rs:18` 12. Reason: "if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit" - Code: `Err(e) => panic!("failed to construct endpoint: {:?}", e),` - Location: `./libs/engine/src/gateway.rs:158` 13. Reason: "we can safely index here, it's inside a test with constant defined fixtures." - Code: `ConductorGateway::execute(request, &gw.routes[0].route_data).await` - Location: `./libs/engine/src/gateway.rs:190` 14. Reason: "if initiating an http client fails, then we have to exit." - Code: `let client = wasm_polyfills::create_http_client().build().unwrap();` - Location: `./plugins/jwt_auth/src/jwks_provider.rs:49` 15. Reason: "if the provided VRL code in the config file can't compile, we have to exit." - Code: `panic!("failed to compile vrl program");` - Location: `./plugins/vrl/src/plugin.rs:129` 16. Reason: "`states` is a non-user provided variable" - Code: `.expect("can't merge states when `states` is an empty vector!")` - Location: `./plugins/vrl/src/plugin.rs:146` 17. Reason: "it panics only if the header name is not valid, and we know it is." - Code: `.unwrap()` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:20` 18. Reason: "it panics only if the URL source is not valid, and it's already validated before." - Code: `let url = req.url().unwrap();` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:23` 19. Reason: "it only panics if we are not running in a CF context, should be safe." - Code: `let cf_info = req.cf().unwrap();` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:27` 20. Reason: "unwraps only in special cases where "data:text" is used." - Code: `let http_host = url.host().unwrap().to_string();` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:36` 21. Reason: "we need to exit the process, if the logger can't be correctly set." - Code: `let _guard = tracing::subscriber::set_default(subscriber);` - Location: `./bin/conductor/src/lib.rs:37` 22. Reason: "we need to exit the process, if the provided configuration file is incorrect." - Code: `panic!("Failed to initialize gateway: {:?}", e);` - Location: `./bin/conductor/src/lib.rs:76`Crate: common
📊 Total Expected Usages: 1
expand details
1. Reason: "we're parsing a statically defined constant, we know it works ;)" - Code: `.unwrap()` - Location: `./libs/common/src/graphql.rs:31`Crate: cloudflare_worker
📊 Total Expected Usages: 4
expand details
1. Reason: "it panics only if the header name is not valid, and we know it is." - Code: `.unwrap()` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:20` 2. Reason: "it panics only if the URL source is not valid, and it's already validated before." - Code: `let url = req.url().unwrap();` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:23` 3. Reason: "it only panics if we are not running in a CF context, should be safe." - Code: `let cf_info = req.cf().unwrap();` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:27` 4. Reason: "unwraps only in special cases where "data:text" is used." - Code: `let http_host = url.host().unwrap().to_string();` - Location: `./bin/cloudflare_worker/src/http_tracing.rs:36`Crate: engine
📊 Total Expected Usages: 2
expand details
1. Reason: "if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit" - Code: `Err(e) => panic!("failed to construct endpoint: {:?}", e),` - Location: `./libs/engine/src/gateway.rs:158` 2. Reason: "we can safely index here, it's inside a test with constant defined fixtures." - Code: `ConductorGateway::execute(request, &gw.routes[0].route_data).await` - Location: `./libs/engine/src/gateway.rs:190`Crate: napi
📊 Total Expected Usages: 1
expand details
1. Reason: "we need this" - Code: `panic!("Exited process!")` - Location: `./libs/napi/src/lib.rs:18`Crate: conductor
📊 Total Expected Usages: 2
expand details
1. Reason: "we need to exit the process, if the logger can't be correctly set." - Code: `let _guard = tracing::subscriber::set_default(subscriber);` - Location: `./bin/conductor/src/lib.rs:37` 2. Reason: "we need to exit the process, if the provided configuration file is incorrect." - Code: `panic!("Failed to initialize gateway: {:?}", e);` - Location: `./bin/conductor/src/lib.rs:76`Crate: config
📊 Total Expected Usages: 9
expand details
1. Reason: "part of development docgen CLI" - Code: `.expect("Failed to serialize json schema for config file!");` - Location: `./libs/config/src/generate-json-schema.rs:50` 2. Reason: "part of development docgen CLI" - Code: `.expect("Failed to write the json schema to the file system!");` - Location: `./libs/config/src/generate-json-schema.rs:54` 3. Reason: "statically defined regex pattern, we know it works ;)" - Code: `.unwrap();` - Location: `./libs/config/src/interpolate.rs:18` 4. Reason: "👇" - Code: `let raw_contents = read_to_string(file_path)` - Location: `./libs/config/src/lib.rs:815` 5. Reason: "👇" - Code: `panic!("Failed to interpolate config file, please resolve the above errors");` - Location: `./libs/config/src/lib.rs:847` 6. Reason: "👇" - Code: `parse_config_from_json(&config_string).expect("Failed to parse JSON config file")` - Location: `./libs/config/src/lib.rs:854` 7. Reason: "👇" - Code: `parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file")` - Location: `./libs/config/src/lib.rs:858` 8. Reason: "👇" - Code: `_ => panic!("Unsupported config file extension"),` - Location: `./libs/config/src/lib.rs:875` 9. Reason: "👇" - Code: `None => panic!("Config file has no extension"),` - Location: `./libs/config/src/lib.rs:878`Crate: jwt_auth
📊 Total Expected Usages: 1
This PR contains the following updates:
2.16.1->2.16.12Release Notes
napi-rs/napi-rs (napi-derive)
### [`v2.16.12`](https://redirect.github.com/napi-rs/napi-rs/releases/tag/napi-derive%402.16.12) [Compare Source](https://redirect.github.com/napi-rs/napi-rs/compare/napi-derive@2.16.11...napi-derive@2.16.12) #### What Changed - fix(napi-derive): string enum validate logic [#2213](https://redirect.github.com/napi-rs/napi-rs/issues/2213) [@Brooooooklyn](https://redirect.github.com/Brooooooklyn) - fix(napi-derive): warning in empty enum codegen [#2214](https://redirect.github.com/napi-rs/napi-rs/issues/2214) [@Brooooooklyn](https://redirect.github.com/Brooooooklyn) - fix(napi,napi-derive): ffi lifetime and pointer sound issues [#2216](https://redirect.github.com/napi-rs/napi-rs/issues/2216) [@cathy-sjh](https://redirect.github.com/cathy-sjh) - fix(napi-derive): replace self when function returns `Result` [#2224](https://redirect.github.com/napi-rs/napi-rs/issues/2224) [@CPunisher](https://redirect.github.com/CPunisher) - perf(macro): constructor don't support asynchronous function [#2239](https://redirect.github.com/napi-rs/napi-rs/issues/2239) [@richerfu](https://redirect.github.com/richerfu) - fix(napi-derive): call flush on the BufWriter [#2242](https://redirect.github.com/napi-rs/napi-rs/issues/2242) [@richerfu](https://redirect.github.com/richerfu) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi-derive@2.16.10...napi-derive@2.16.12 ### [`v2.16.11`](https://redirect.github.com/napi-rs/napi-rs/releases/tag/napi-derive%402.16.11) [Compare Source](https://redirect.github.com/napi-rs/napi-rs/compare/napi-derive@2.16.10...napi-derive@2.16.11) #### What Changed - fix(napi-derive): add more cases for typegen of function args by [@CPunisher](https://redirect.github.com/CPunisher) [#2210](https://redirect.github.com/napi-rs/napi-rs/issues/2210) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi-derive@2.16.10...napi-derive@2.16.11 ### [`v2.16.10`](https://redirect.github.com/napi-rs/napi-rs/releases/tag/napi%402.16.10) [Compare Source](https://redirect.github.com/napi-rs/napi-rs/compare/napi-derive@2.16.9...napi-derive@2.16.10) #### What Changed - fix(napi,napi-derive): ffi lifetime and pointer sound issues [https://github.com/napi-rs/napi-rs/pull/2216](https://redirect.github.com/napi-rs/napi-rs/pull/2216) [@cathy-sjh](https://redirect.github.com/cathy-sjh) - chore(napi): mark JsArraybufferValue's value pub [https://github.com/napi-rs/napi-rs/pull/2226](https://redirect.github.com/napi-rs/napi-rs/pull/2226) [@richerfu](https://redirect.github.com/richerfu) - fix(napi): use error_ref should checkout it at first [https://github.com/napi-rs/napi-rs/pull/2235](https://redirect.github.com/napi-rs/napi-rs/pull/2235) [@richerfu](https://redirect.github.com/richerfu) - fix(napi): windows function registration timing [https://github.com/napi-rs/napi-rs/pull/2248](https://redirect.github.com/napi-rs/napi-rs/pull/2248) [@Brooooooklyn](https://redirect.github.com/Brooooooklyn) - perf(napi): remove unnecessary checks for strings from napi_get_value_string_utf8 [#2247](https://redirect.github.com/napi-rs/napi-rs/issues/2247) [@SyMind](https://redirect.github.com/SyMind) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi@2.16.9...napi@2.16.10 ### [`v2.16.9`](https://redirect.github.com/napi-rs/napi-rs/releases/tag/napi-derive%402.16.9) [Compare Source](https://redirect.github.com/napi-rs/napi-rs/compare/napi-derive@2.16.8...napi-derive@2.16.9) #### What's Changed - fix: napi getter macros by [@SyMind](https://redirect.github.com/SyMind) in [https://github.com/napi-rs/napi-rs/pull/2188](https://redirect.github.com/napi-rs/napi-rs/pull/2188) #### New Contributors - [@SyMind](https://redirect.github.com/SyMind) made their first contribution in [https://github.com/napi-rs/napi-rs/pull/2188](https://redirect.github.com/napi-rs/napi-rs/pull/2188) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi-derive@2.16.8...napi-derive@2.16.9 ### [`v2.16.8`](https://redirect.github.com/napi-rs/napi-rs/releases/tag/napi-derive%402.16.8) [Compare Source](https://redirect.github.com/napi-rs/napi-rs/compare/napi-derive@2.16.7...napi-derive@2.16.8) #### What changed - fix(napi-derive): missing declare keyword for function **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi-derive@2.16.7...napi-derive@2.16.8 ### [`v2.16.7`](https://redirect.github.com/napi-rs/napi-rs/releases/tag/napi-derive%402.16.7) [Compare Source](https://redirect.github.com/napi-rs/napi-rs/compare/napi-derive@2.16.6...napi-derive@2.16.7) #### What Changed - fix(napi-derive): class constructor and factory should support custom error status by [@richerfu](https://redirect.github.com/richerfu) [#2161](https://redirect.github.com/napi-rs/napi-rs/issues/2161) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi@2.16.8...napi-derive@2.16.7 ### [`v2.16.6`](https://redirect.github.com/napi-rs/napi-rs/compare/napi-derive@2.16.5...napi-derive@2.16.6) [Compare Source](https://redirect.github.com/napi-rs/napi-rs/compare/napi-derive@2.16.5...napi-derive@2.16.6) ### [`v2.16.5`](https://redirect.github.com/napi-rs/napi-rs/releases/tag/napi%402.16.5) [Compare Source](https://redirect.github.com/napi-rs/napi-rs/compare/napi-derive@2.16.4...napi-derive@2.16.5) #### What's Changed - Fix panic in JsArrayBufferValue as_ref/as_mut with Rust 1.78 by [@tronical](https://redirect.github.com/tronical) in [https://github.com/napi-rs/napi-rs/pull/2083](https://redirect.github.com/napi-rs/napi-rs/pull/2083) - fix(napi): make sure env without exception pending before throw error by [@southorange0929](https://redirect.github.com/southorange0929) in [https://github.com/napi-rs/napi-rs/pull/2092](https://redirect.github.com/napi-rs/napi-rs/pull/2092) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi@2.16.4...napi@2.16.5 ### [`v2.16.4`](https://redirect.github.com/napi-rs/napi-rs/releases/tag/napi%402.16.4) [Compare Source](https://redirect.github.com/napi-rs/napi-rs/compare/napi-derive@2.16.3...napi-derive@2.16.4) #### What changed - feat(napi): allow user defined tokio runtime by [@Brooooooklyn](https://redirect.github.com/Brooooooklyn) [#2040](https://redirect.github.com/napi-rs/napi-rs/issues/2040) - fix(napi): handle panic in async block by [@Brooooooklyn](https://redirect.github.com/Brooooooklyn) ([https://github.com/napi-rs/napi-rs/pull/2050](https://redirect.github.com/napi-rs/napi-rs/pull/2050)) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi@2.16.2...napi@2.16.4 ### [`v2.16.3`](https://redirect.github.com/napi-rs/napi-rs/compare/napi@2.16.2...napi@2.16.3) [Compare Source](https://redirect.github.com/napi-rs/napi-rs/compare/napi-derive@2.16.2...napi-derive@2.16.3) ### [`v2.16.2`](https://redirect.github.com/napi-rs/napi-rs/releases/tag/napi-derive%402.16.2) [Compare Source](https://redirect.github.com/napi-rs/napi-rs/compare/napi-derive@2.16.1...napi-derive@2.16.2) ##### What's Changed - feat(napi-derive): enhance the error messages in object validator by [@Brooooooklyn](https://redirect.github.com/Brooooooklyn) in [https://github.com/napi-rs/napi-rs/pull/2034](https://redirect.github.com/napi-rs/napi-rs/pull/2034) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi-derive@2.16.1...napi-derive@2.16.2Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.