the-guild-org / the-guild-docs

Low level and completely custom documentation websites using Next.js
https://the-guild-docs.vercel.app
22 stars 7 forks source link

Giscus mapping option is not supported #490

Closed n1ru4l closed 2 years ago

n1ru4l commented 2 years ago

On Yoga, we already used the "pathname" mapping.

<Script
        src="https://giscus.app/client.js"
        data-repo="dotansimha/graphql-yoga"
        data-repo-id="MDEwOlJlcG9zaXRvcnkxMTA4MTk5Mzk="
        data-category="Docs Discussion"
        data-category-id="DIC_kwDOBpr6Y84CAquY"
        data-mapping="pathname"
        data-reactions-enabled="1"
        data-emit-metadata="0"
        data-theme="preferred_color_scheme"
        data-lang="en"
        crossOrigin="anonymous"
        async
      />

It is impossible to provide the mapping configuration via the current config object

  {
    giscus: {
      repo: 'dotansimha/graphql-yoga',
      repoId: 'MDEwOlJlcG9zaXRvcnkxMTA4MTk5Mzk=',
      category: '"Docs Discussion',
      categoryId: 'DIC_kwDOBpr6Y84CAquY',
    },
  },
n1ru4l commented 2 years ago

I just discovered a typo :D It seems like pathname is the default 🥳