the-hideout / TarkovMonitor

Monitor Tarkov log files to help track progress, queues, and groups
GNU General Public License v3.0
91 stars 16 forks source link

Feature request. Automatically load previous logs. #47

Closed 1337cookie closed 7 months ago

1337cookie commented 8 months ago

If I run "Force Read Log Files" in chronological order it updates my untracked tasks. Would be cool if there was a button to do this OR we could just select all the logs to load simultaneously.

squidninja17 commented 8 months ago

I second this. Sounds 100% doable and should be an essential feature.

gaschenk commented 8 months ago

While this is possible and I would have a rough draft, you will run into the issue that a lot of requests will timeout as TarkovMonitor hasn't been built with resiliency in mind regarding Tarkov Tracker and accessing its API.

Razzmatazzz commented 8 months ago

Yes, there is the rate limit issue with Tarkov Tracker's API. We would have to build in some metering to make sure we don't exceed the limit.

But there's also the issue of knowing how far back to read logs. Would need to know the start of the current wipe in order to avoid reading logs from last wipe. There's also the issue of reading logs from a different account if the user has more than one EFT account. I suppose one way to solve all that would be to let the user specify how far back to go with the logs.

gaschenk commented 7 months ago

Would need to know the start of the current wipe in order to avoid reading logs from last wipe.

In that regard it would be an option to differentiate if it's a previous wipe, if the newest Version has a different minor version, at least that's as far as I'm aware when normally a wipe should have happened, so it would allow to read just every log, parse every log entry, sort by date, filter out any version entry that has a different minor version from the current version.

Furthermore in regard to logs and being able to find new information, you could attempt to change NLog.config and set everything to TRACE and well hope to see something new, potentially that is.

Razzmatazzz commented 7 months ago

It's an interesting idea to use the minor version number as a cutoff to read previous logs, wipes don't always perfectly coincide with a new minor version.

As for editing the NLog.config, I believe that will cause the game to fail integrity checks.

gaschenk commented 7 months ago

As for editing the NLog.config, I believe that will cause the game to fail integrity checks.

In fact it does.

As for well fixing certain stuff up, I'd recommend looking at Refit in order to implement a TarkovTracker API, which could potentially be it's own personal Library and with Libraries such as Polly you could easily add rate limiting.

Not to mention a lot of stuff should be split up, such as parsing the log files, and you don't have to separate based on the name of the file, as that even is the incorrect way to distinguish, where something gets logged.

ar1a commented 7 months ago

Is there an option of retrieving task data from tarkovtracker in bulk, checking for discrepancies between the local state that's been rebuilt (from the "force read all logs" button), and then only submitting changes for each task that's mismatched, instead of checking all 340 tasks one api call after the other