the-hideout / tarkov-dev

The official site for tarkov.dev - A web app to track item prices, view trader barters, quests, maps, and much more!
https://tarkov.dev
MIT License
130 stars 48 forks source link

Ammo Graph Not Updating Based on Toggles #278

Open Reithan opened 1 year ago

Reithan commented 1 year ago

Describe the Issue

When using the "new" ammo chart toggles to hide/show ammo based on availability, the chart updates to hide some ammo, but the graph does not.

The "total damage" toggle affects the graph properly, so I would expect the "ignore settings" toggle to be the same

Expected Behavior

Expected that if "ignore settings" is off, unavailable ammo would be hidden on the above graph.

To Reproduce

Set low traders or turn off flea and toggle "ignore settings" on/off

Client

Desktop

Browser

Chrome

Relevant Console Log Output

No response

Extra Information

No response

Razzmatazzz commented 1 year ago

I see this somewhat differently. Even if ammo is "unavailable" because you can't buy it directly from traders or craft it, it's still possible that you might find that ammo in raid and want to know its attributes.

Reithan commented 11 months ago

I see this somewhat differently. Even if ammo is "unavailable" because you can't buy it directly from traders or craft it, it's still possible that you might find that ammo in raid and want to know its attributes.

As long as we have the "Ignore settings" toggle, I think that accounts for that use case.

My main want is, as a relatively shitty Tarkov player myself, am interested in figuring out, "At my current trader level, what's my best bang-for-buck ammo type?"

So, my 'desired' search would be the ability to filter the chart & list down to ammo that is purchasable by me at my current trade/flea unlock level, and then filter further by price so I can see what the available damage vs pen options available to me look like.

The pen range slider that was added is super helpful too, but that would probably be the 2nd or 3rd step I'd want to narrow down to the ammo type I'm looking to find a weapon and fill with it.

Razzmatazzz commented 11 months ago

Can't that basically be achieved by sorting by cheapest price (ascending) and filtering by minimum penetration? Anything without a price sinks to the bottom of the list.

Reithan commented 11 months ago

For the list at the bottom, that works well if I've already picked a caliber, or if I've set the upper/lower limit on pen relatively narrow. But if I'm trying to also visually identify the range of pen vs damage across multiple calibers, it can get pretty cluttered.

To clarify though, this is also specifically about the graph updating, not the list at the bottom, where the only filters that affect it are the pen slider and caliber selector.

Razzmatazzz commented 11 months ago

Fair enough. I'm not opposed to the feature if someone wants to code it and submit a PR.

brjens commented 2 months ago

@Reithan does this solve the issue? I made it so it just affects the graph, and only shows what you can buy with your traders.

Reithan commented 2 months ago

@brjens The new "Trader Ammo" toggle is working with the graph as I wanted, although the "Ignore Settings" toggle still seems to be working oddly? I don't see anything changing on the graph whether "Trader Ammo" is on or off.