the-hideout / tarkov-dev

The official site for tarkov.dev - A web app to track item prices, view trader barters, quests, maps, and much more!
https://tarkov.dev
MIT License
141 stars 51 forks source link

Strings that cannot be currently translated #364

Closed Faalagorn closed 8 months ago

Faalagorn commented 1 year ago

Describe the Feature Request

Following the discussion on Discord and in #362 and #363, here are the strings that currently can't be translated:

Related issue: #175.

Shebuka commented 1 year ago

@Razzmatazzz do we need to translate boss descriptions manually?

Shebuka commented 1 year ago

For chart of item price hisotry, do we want relative dates or full dates?

Relative: Screenshot 2023-02-06 at 12 59 17

Full: Screenshot 2023-02-06 at 13 04 30

Shebuka commented 1 year ago

@Razzmatazzz do you have a list of all the properties we can receive from the API to translate?

Faalagorn commented 1 year ago

For chart of item price hisotry, do we want relative dates or full dates?

Relative: Screenshot 2023-02-06 at 12 59 17

Full: Screenshot 2023-02-06 at 13 04 30

It would be nice if the full dates would take into account locale customization, especially the MM/DD/YYYY or DD/MM/YYYY – not sure if it should be set by translation or user-customizable (or ideally both), though I personally am fan of YYYY-MM-DD anyway :P

Shebuka commented 1 year ago

locale customization

It should take into account the default locale format of the selected language

Razzmatazzz commented 1 year ago

@Razzmatazzz do we need to translate boss descriptions manually?

Yes, descriptions are currently in /src/data/boss.json. We should probably add them to the translation files with the keys something like {normalizedBossName}Desc;

Razzmatazzz commented 1 year ago

@Razzmatazzz do you have a list of all the properties we can receive from the API to translate?

Sort of. All the properties we're currently querying can be found in the items query.

And some labeling substitutions for property names are done here.

Shebuka commented 1 year ago

descriptions are currently in /src/data/boss.json

And we have no plans to add descriptions (localized) to the API?

Razzmatazzz commented 1 year ago

descriptions are currently in /src/data/boss.json

And we have no plans to add descriptions (localized) to the API?

We hadn't really discussed it yet. I don't think we have similar "flavor" text added for anything else. But we do need a better way to manage the manual translations we already have

Shebuka commented 1 year ago

Updated the first post with all the fixed ones by #365

Faalagorn commented 1 year ago

Seems that stats for items are still in English at least for me? and I can't find them in https://github.com/the-hideout/tarkov-dev/blob/main/src/translations/pl/translation.json screenshot_2023-02-08-193802 screenshot_2023-02-08-193755

I also can't find the boss descriptions? Seems @Razzmatazzz mentioned it two comments above?

The rest should be fixed added to Polish by #371, thanks!

Shebuka commented 1 year ago

@Faalagorn Look in the en translation folder, there are two new files, one for properties translation and one for bosses description: https://github.com/the-hideout/tarkov-dev/tree/main/src/translations/en

Faalagorn commented 1 year ago

@Faalagorn Look in the en translation folder, there are two new files, one for properties translation and one for bosses description: https://github.com/the-hideout/tarkov-dev/tree/main/src/translations/en

Ah, thanks! I'll take a look tomorrow or so then!

BTW, kinda offtopic, but I was wondering where that screenshot you posted in https://github.com/the-hideout/tarkov-dev/issues/175#issuecomment-1404739258 come from? Is it public, so can I check it myself, does it take into accounts the strings in those two files? Probably best to check it after #371 gets merged, but is Polish close to 100% now, or did I miss something?

Shebuka commented 1 year ago

that screenshot you posted

@Faalagorn In the first comment https://github.com/the-hideout/tarkov-dev/issues/175#issue-1323314087 under the section How you can help! there is the link https://poeditor.com/join/project/YA8ZrCsxTi to join our localization management project in POEditor

Faalagorn commented 1 year ago

@Shebuka Thanks! I didn't knew that. Is it better to contibute translations via GitHub or via the website? I assume website might be easier to not mess the tags and miss terms to translate, but not sure if it's easier for you guys to do it via GH PRs?

Faalagorn commented 1 year ago

Found one more string group, on trader pages, e.g. https://tarkov.dev/traders/jaeger when you hover to the loyality levels, a tooltip is displayed in English.

Shebuka commented 1 year ago

Many more fixes to translation strings with #388

I think they are basically all translated now, minus the ammo caliber and this https://tarkov.dev/loot-tier/ – No options which I don't see on the loot tier page.