Strings that can't be translated

the-hideout / tarkov-dev

The official site for tarkov.dev - A web app to track item prices, view trader barters, quests, maps, and much more!

https://tarkov.dev

MIT License

145 stars 52 forks source link

Strings that can't be translated #812

Open Faalagorn opened 9 months ago

Faalagorn commented 9 months ago

Describe the Issue

Seems there's still a few strings that can't be translated

Expected Behavior

This strings should be translated.

To Reproduce

Change language, go to respective page, notice these strings are still in English

~~1. At any page hover over maps, see "More…" (there is already a translation for More without the dots; maybe it could be used?~~

Kollontay at https://tarkov.dev/boss/kollontay (this could be obtained from game files), as well as description ~~3. Toggle SortBy at https://tarkov.dev/barters/ when hovering~~
Interactive at https://tarkov.dev/maps/

Client

Desktop

Browser

Firefox

Relevant Console Log Output

No response

Extra Information

There are some missing translations in #806 and #805 while at it.

Faalagorn commented 9 months ago

I updated the main post; seems the "more…" issue was somehow solved,

However, I found a few more:

In https://tarkov.dev/loot-tier/ when you group item together, translations are not consistently applied (Gun and Wearable are not translated for me, even if they were previously)
Armor zones are not translated, though it may be because the new strings were not applied?

Faalagorn commented 8 months ago

Cookie notice can't be translated either:

tarkov.dev uses cookies to enhance your experience. By continuing to use this site, you agree to the usage of cookies. Cookies are used to remember your settings and features that you enable. as well as the "I understand" button.

This can be hidden by some adblock filter lists, mind you.

Faalagorn commented 8 months ago

There's another one in the map – "Caches" (and Lexos, though not sure if any language actually need to translate it): https://tarkov.dev/maps/

Razzmatazzz commented 8 months ago

It seems like a lot of these aren't strings that "can't" be translated; they're just strings missing from the Polish translation files.

Edited to add: number 3 in the above list has been fixed by removing the tooltip (since it wasn't very helpful in the first place).

Also, the Kollantay boss name doesn't appear in the game translation files, so its translation is handled by the Data Manager to supply the API with the needed translations. We don't currently have a Polish translation for the data manager, but you can see which strings need translations by looking at the English translation file.

Faalagorn commented 8 months ago

Thank you! Indeed, some of the strings were not updated for Polish, but I did the PRs with them missing, hopefully most will be fixed. I also made a PR to tarkov-data-manager, so hopefully more things will be transalted now.

However, there are still few strings missing even in the English file:

Achievements (that's a new additions, they aren't translated in game either)
Cookie notice (can't find it anywhere)
"Map of" when howevering over the any map in https://tarkov.dev/maps/
Caches and Lexos are still not there in English maps.json
And there's still that weird issue of https://tarkov.dev/loot-tier/ when you group item together and translations are not consistently applied (Gun and Wearable)