Migration from CommonJS to ECMAScript

the-hideout / tarkov-dev

The official site for tarkov.dev - A web app to track item prices, view trader barters, quests, maps, and much more!

https://tarkov.dev

MIT License

144 stars 52 forks source link

Migration from CommonJS to ECMAScript #819

Closed Shebuka closed 8 months ago

Shebuka commented 8 months ago

Everywhere I look CommonJS is being replaced by either ECMAScript (easy) or TypeScript (hard). Let's go the easy route first and get ECMAScript to work. As example, not being compatible with ESM is what blocked us from updating critical from v4 to the current v6.

Updated critical from v4 to v6;
Updated other dependencies;
Added jest to eslint config
Enabled ECMAScript modules in package.json
Fixed Icon import from @mdi/react to not crash the site with ECMAScript modules
Root DOM creation from recent create-react-app
Convert require -> import
Refactoring indentation
Renamed scripts to mjs so they can be treated as ESM but keep the website as it as before
As required by ESM we now import directly js files
Converted scripts to ESM

github-actions[bot] commented 8 months ago

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

👀 Observe the CI jobs and tests to ensure they are passing
✔️ Obtain an approval/review on this pull request
🚀 Deploy your pull request to the development environment with .deploy to development
🚀 Deploy your pull request to the production environment with .deploy

If anything goes wrong, rollback with .deploy main
🎉 Merge!

Note: If you have a larger change and want to block deployments, you can run .lock --reason <reason> to lock all other deployments (remove with .unlock)

You can view the branch deploy usage guide for additional information

Shebuka commented 8 months ago

.deploy to development

github-actions[bot] commented 8 months ago

Deployment Triggered 🚀

Shebuka, started a branch deployment to development

You can watch the progress here 🔗

Branch: feature/cjs_to_esm

github-actions[bot] commented 8 months ago

Deployment Results ❌

Shebuka had a failure when deploying branch feature/cjs_to_esm to development

Shebuka commented 8 months ago

.deploy to development

github-actions[bot] commented 8 months ago

Deployment Triggered 🚀

Shebuka, started a branch deployment to development

You can watch the progress here 🔗

Branch: feature/cjs_to_esm

github-actions[bot] commented 8 months ago

Deployment Results ✅

Shebuka successfully deployed branch feature/cjs_to_esm to development

Show Results

https://6f413d64.tarkov-dev.pages.dev

Shebuka commented 8 months ago

.deploy

github-actions[bot] commented 8 months ago

Deployment Triggered 🚀

Shebuka, started a branch deployment to production

You can watch the progress here 🔗

Branch: feature/cjs_to_esm

github-actions[bot] commented 8 months ago

Deployment Results ✅

Shebuka successfully deployed branch feature/cjs_to_esm to production

Environment URL: tarkov.dev