search

the-hideout / tarkov-dev

The official site for tarkov.dev - A web app to track item prices, view trader barters, quests, maps, and much more!
https://tarkov.dev
MIT License
131 stars 48 forks source link

Items pages description translation and more #847

Closed Shebuka closed 5 months ago

Shebuka commented 5 months ago

Fixed some translations and QoL improvements:

github-actions[bot] commented 5 months ago

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Deploy your pull request to the development environment with .deploy to development

  4. 🚀 Deploy your pull request to the production environment with .deploy

    If anything goes wrong, rollback with .deploy main

  5. 🎉 Merge!

Note: If you have a larger change and want to block deployments, you can run .lock --reason <reason> to lock all other deployments (remove with .unlock)

You can view the branch deploy usage guide for additional information

Shebuka commented 5 months ago

less likely to diligently update those values

But you need to update your player level in TarkovTracker, otherwise, the quests will not be shown even if you completed the previous one.

I think the locked quests switch is black magic for the final user anyway so it will be fine 😅

tasks table, it doesn't display player or trader level

It shows the minimum player level as the third column 🤔 or do you refer to something else?

Shebuka commented 5 months ago

.deploy

github-actions[bot] commented 5 months ago

Deployment Triggered 🚀

Shebuka, started a branch deployment to production

You can watch the progress here 🔗

Branch: feature/items_pages_translation

github-actions[bot] commented 5 months ago

Deployment Results ✅

Shebuka successfully deployed branch feature/items_pages_translation to production

Environment URL: tarkov.dev

Razzmatazzz commented 5 months ago

But you need to update your player level in TarkovTracker, otherwise, the quests will not be shown even if you completed the previous one.

I think the locked quests switch is black magic for the final user anyway so it will be fine 😅

Fair point!

It shows the minimum player level as the third column 🤔 or do you refer to something else?

Ah, that's what I get for looking at the page on mobile.