search

the-hideout / tarkov-dev

The official site for tarkov.dev - A web app to track item prices, view trader barters, quests, maps, and much more!
https://tarkov.dev
MIT License
131 stars 48 forks source link

Add factory map labels #854

Closed BlaneWins closed 4 months ago

BlaneWins commented 4 months ago

[Factory Map Labels]

Added all labels for the map factory.

Description 🗒️

Labeled locations according to ,in my opinion: the biggest pvp area call-outs, iconic landmarks, and quest locations. Includes labels set to correct height showing only their respective floors, however there is a bug leading to them all to show on initial load, see below for more details on the issue.

Examples 📸

Screenshot 2024-02-12 at 3 45 53 PM Screenshot 2024-02-12 at 3 46 17 PM Screenshot 2024-02-12 at 3 46 31 PM Screenshot 2024-02-12 at 3 46 51 PM

Related Issues 🔗

Partial addition to #840

New issue needs to be opened for labels appearing on all height sections of the map on initial load until a floor is checked.

Expand for Help - Have questions about the review or deployment process? View our [contributing docs](https://github.com/the-hideout/tarkov-dev/blob/main/CONTRIBUTING.md) - Need additional help and want to chat in real time? Join our [community Discord](https://discord.gg/XPAsKGHSzH) > By submitting this pull request, you agree to our [code of conduct](https://github.com/the-hideout/tarkov-dev/blob/main/CODE_OF_CONDUCT.md)
Shebuka commented 4 months ago

Can you fix the floor top and bottom? They should match the height of the floors

Tunnels
"height": [-10000, -1]

1st floor
"heightRange": [-1, 3]

2nd Floor
"height": [3, 6]

3rd Floor
"height": [6, 10000]

Maybe it's the culprit of the initialization bug too

Razzmatazzz commented 4 months ago

@BlaneWins Thanks for the PR! To expand a bit more on what Shebuka said, the top and `bottom properties of each label are meant to give labels a total height range within which they should be displayed. If that height range spans across multiple floor layers of the map, the labels will be displayed on all such layers.

BlaneWins commented 4 months ago

Ofc, here's the new commit for range spanning the full height of the floors. Let me know if this is what you meant. Still having them all appear on initialization.

Shebuka commented 4 months ago

.deploy

github-actions[bot] commented 4 months ago

Deployment Triggered 🚀

Shebuka, started a branch deployment to production

You can watch the progress here 🔗

Branch: 3829036bfc897af557234caa30009f55b51f0e87

github-actions[bot] commented 4 months ago

Deployment Results ✅

Shebuka successfully deployed branch 3829036bfc897af557234caa30009f55b51f0e87 to production

Environment URL: tarkov.dev