search

the-hideout / tarkov-dev

The official site for tarkov.dev - A web app to track item prices, view trader barters, quests, maps, and much more!
https://tarkov.dev
MIT License
130 stars 48 forks source link

Filter by Caliber side table vertical dimension doesnt fit properly #908

Closed AphidRS closed 3 months ago

AphidRS commented 3 months ago

Describe the Issue

The "Filter by caliber" side table on ammo chart doesnt display properly on his vertical dimension. The last ammo item is barely see.

Expected Behavior

All the ammo items must fit correctly inside the table.

To Reproduce

Go to https://tarkov.dev/ammo/ and ckeck the last ammo item in the filter by caliber list (9x39 mm)

Client

Desktop

Browser

Firefox

Relevant Console Log Output

No response

Extra Information

imagen

AphidRS commented 3 months ago

I have fixed the Graph.jsx VictoryChart height to fix this, tell me to open a PR to merge.

Razzmatazzz commented 3 months ago

Thanks for fixing!

AphidRS commented 3 months ago

@Razzmatazzz I have noticed that it didnt fixed as expected, must i open another issue or can i create a PR to address this directly ¿?

Razzmatazzz commented 3 months ago

@AphidRS I re-opened the issue. I think you did actually fix the issue, but the game added the 20x1mm toy gun ammo, which shifted everything down another line. Wondering if we should just suppress that ammo type from the chart since it's basically a joke.

Razzmatazzz commented 3 months ago

@AphidRS I created a PR that makes the height dynamic based on the number of calibers, which should resolve the issue regardless of how many new calibers are added.

AphidRS commented 3 months ago

@Razzmatazzz Many thanks!, way better definitive solution ! Thanks ;)