search

the-hideout / tarkov-dev

The official site for tarkov.dev - A web app to track item prices, view trader barters, quests, maps, and much more!
https://tarkov.dev
MIT License
130 stars 48 forks source link

UI minor changes to improve legibility #918

Closed AphidRS closed 2 months ago

AphidRS commented 2 months ago

[UI minor changes to improve legibility UPDATED]

Minor style changes in App, data-table, menu, item and start css files to improve tables legibility and color contrast without modifying the original palette colors.

Screenshots🗒️

imagen

imagen

imagen

Razzmatazzz commented 2 months ago

.deploy to development

github-actions[bot] commented 2 months ago

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to development

You can watch the progress here 🔗

Branch: 9ca6b94c352bc53fd4200fcd25c35301d95b0301

github-actions[bot] commented 2 months ago

Deployment Results ✅

Razzmatazzz successfully deployed branch 9ca6b94c352bc53fd4200fcd25c35301d95b0301 to development

Show Results https://b39c1792.tarkov-dev.pages.dev
AphidRS commented 2 months ago

As requested, please review this new proposal of UI color style changes.

Razzmatazzz commented 2 months ago

Thank you for this PR! We should have raised concerns here rather than in Discord to keep things in one place, but thank you for making tweaks based on feedback. Will try to keep future discussion here so it's easier to follow. I hope to take a look in earnest later today (but someone else might get to it first). Will do a test deploy for now though.

Razzmatazzz commented 2 months ago

.deploy to development

github-actions[bot] commented 2 months ago

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to development

You can watch the progress here 🔗

Branch: 14028e043a9157100cbfad16535bd0d72fd40b77

github-actions[bot] commented 2 months ago

Deployment Results ✅

Razzmatazzz successfully deployed branch 14028e043a9157100cbfad16535bd0d72fd40b77 to development

Show Results https://4e670186.tarkov-dev.pages.dev
AphidRS commented 2 months ago

Thank you, i read all the conversation this morning so i tried to take all the considerations into this. But if you do not agree with this new PR, no problem ;)

Razzmatazzz commented 2 months ago

Sorry for taking so long to get to this! Theme changes are always kind of fraught because people tend to have strong feelings on how things should look. Thank you for taking the time to make the initial PR and for this revision. The smoky background is a cool touch, imo. Unfortunately, I've been elected by the core maintainers to convey the message that this is a bit too much of a change. It really changes the overall feel of the site and makes things much darker feeling. That doesn't necessarily make it "wrong", but there's some concern that the original site's character gets somewhat lost. Maybe for starters, just start with smaller tweaks like making the background ~ 2% darker and changing the link color to something slightly lighter (e.g., in the neighborhood of #cab286) but maintaining the current link color for hovers.

Again, we really appreciate your efforts on this, and we don't want to discourage you from contributing more in the future. Big theme changes can just be rather controversial and it seems we're a bit stuck in our ways in that regard.

P.S. If you want to spin your translation additions off into a separate PR, we can get those merged ASAP.

AphidRS commented 2 months ago

I understand @Razzmatazzz, thank you for taking this into consideration anyway. I really thought that it wouldn't be approved, but i had a lot of fun trying to get a more attractive look and feel for the site. The translations will be finished on this weekend so i´ll create the PR when done.

Razzmatazzz commented 2 months ago

Ok, thanks again for all the effort. It is very much appreciated.