the-infocom-files / ballyhoo

Ballyhoo
5 stars 4 forks source link

"GIVE HAND TO ..." maybe doesn't work as intended? #61

Open eriktorbjorn opened 4 years ago

eriktorbjorn commented 4 years ago

In PRE-GIVE, there's a special case for your hands:

<ROUTINE PRE-GIVE ()
     <COND (<AND <VERB? GIVE>
             <PRSO? ,HANDS>>
        <COND (<PRSI? ,HYP>
               <SETG WINNER ,HYP>
               <PERFORM ,V?READ ,HANDS>
               <SETG WINNER ,PROTAGONIST>
               <RTRUE>)>
        <PERFORM ,V?SHAKE-WITH ,PRSI>
        <RTRUE>)
           (<IDROP>
        <RTRUE>)>>

So it looks like "GIVE HAND TO someone" should be equivalent to "SHAKE HANDS WITH someone". Though if so, it should be <PERFORM ,V?SHAKE-WITH ,PRSO ,PRSO> because right now all you get is "[That sentence isn't one I recognize.]"

Though I think there are other sensible ways the game could have interpreted "GIVE HAND TO someone", e.g. as "HELP someone" or "APPLAUD someone", so I don't know if it should be changed or not...