the-infocom-files / moonmist

Moonmist
4 stars 3 forks source link

The game should probably use <SETG NEW-VOC? T> #13

Open eriktorbjorn opened 3 years ago

eriktorbjorn commented 3 years ago

When enabling all ZILF warnings, compiling the game produces (among others) this:

[warning ZIL0308] <top level>: too many parts of speech for 'UPSTAIRS': Adjective (people.zil:1941), Direction (moonmist.zil:12), Preposition (syntax.zil:117)
[warning ZIL0306] people.zil:1941: discarding the Adjective part of speech for 'UPSTAIRS'
[warning ZIL0308] <top level>: too many parts of speech for 'SPRAY': Object (things.zil:198), Adjective (castle.zil:1866), Verb (syntax.zil:600)
[warning ZIL0306] castle.zil:1866: discarding the Adjective part of speech for 'SPRAY'
[warning ZIL0308] <top level>: too many parts of speech for 'PUNCH': Verb (syntax.zil:647), Adjective (tower.zil:1402), Object (tower.zil:1403)
[warning ZIL0306] tower.zil:1402: discarding the Adjective part of speech for 'PUNCH'
[warning ZIL0308] <top level>: too many parts of speech for 'SLAP': Adjective (tower.zil:1402), Object (tower.zil:1403), Verb (syntax.zil:647)
[warning ZIL0306] tower.zil:1402: discarding the Adjective part of speech for 'SLAP'
[warning ZIL0308] <top level>: too many parts of speech for 'HIT': Adjective (tower.zil:1402), Object (tower.zil:1403), Verb (syntax.zil:647)
[warning ZIL0306] tower.zil:1402: discarding the Adjective part of speech for 'HIT'
[warning ZIL0308] <top level>: too many parts of speech for 'KICK': Adjective (tower.zil:1402), Object (tower.zil:1403), Verb (syntax.zil:647)
[warning ZIL0306] tower.zil:1402: discarding the Adjective part of speech for 'KICK'
[warning ZIL0308] <top level>: too many parts of speech for 'DRIVE': Adjective (castle.zil:326), Object (global.zil:646), Verb (syntax.zil:822)
[warning ZIL0306] castle.zil:326: discarding the Adjective part of speech for 'DRIVE'

The original moonmist.zil used <SETG NEW-VOC? T>. Adding that shortens the list of vocabulary warnings to:

[warning ZIL0308] <top level>: too many parts of speech for 'UPSTAIRS': Adjective (people.zil:1941), Direction (moonmist.zil:13), Preposition (syntax.zil:117)
[warning ZIL0306] people.zil:1941: discarding the Adjective part of speech for 'UPSTAIRS'
eriktorbjorn commented 3 years ago

I should probably apply this change locally for the rest of the testing.