search

the-infocom-files / moonmist

Moonmist
4 stars 3 forks source link

"FIND LENS" prints Frotz warnings #27

Open eriktorbjorn opened 3 years ago

eriktorbjorn commented 3 years ago 
>INVENTORY
You are holding the second contact lens, the first contact lens, the small
plastic box, the aerosol device and the tweed outfit (actually, wearing it).

>FIND LENS
Warning: @test_attr called with object 0 (PC = ab9e) (will ignore further
occurrences)
Warning: @get_prop called with object 0 (PC = c20d) (will ignore further
occurrences)
It's far away from here.

Address ab9e is in the SEE-INSIDE? routine, and c20d is in the FAR-AWAY? routine. The way the GENERIC-LENS routine is written, it will use the LENS object, not the LENS-1 or LENS-2 objects I was carrying:

<ROUTINE GENERIC-LENS (X "OPTIONAL" Y)
 <COND (<REMOTE-VERB?>
    ,LENS)
       (<NOT <FSET? ,LENS-2 ,SEENBIT>>
    ,LENS-1)>>

And the LENS object has been removed, i.e. it has on parent. I assume it's trying to check attributes/properties on that non-existing parent object.

I'm not sure what's the best way of fixing it. In fact, I'm not even sure what the purpose is. It seems odd that it picks LENS over the lenses I'm carrying...