the-infocom-files / moonmist

Moonmist
4 stars 3 forks source link

Warning fixes #3

Open eriktorbjorn opened 5 years ago

eriktorbjorn commented 5 years ago

This fixes most - not all - of the warnings produced by ZILF 0.9. I think this is a good idea, because otherwise warnings and errors tend to get lost in the noise.

The remaining warnings are:

[warning ZIL0210] parser.zil:2883: local variable 'ADJ' is never used
[warning ZIL0308] <top level>: too many parts of speech for 'UPSTAIRS': Adjective (people.zil:1941), Direction (moonmist.zil:12), Preposition (syntax.zil:117)
[warning ZIL0306] people.zil:1941: discarding the Adjective part of speech for 'UPSTAIRS'
[warning ZIL0308] <top level>: too many parts of speech for 'SPRAY': Object (things.zil:198), Adjective (castle.zil:1866), Verb (syntax.zil:600)
[warning ZIL0306] castle.zil:1866: discarding the Adjective part of speech for 'SPRAY'
[warning ZIL0308] <top level>: too many parts of speech for 'PUNCH': Verb (syntax.zil:647), Adjective (tower.zil:1402), Object (tower.zil:1403)
[warning ZIL0306] tower.zil:1402: discarding the Adjective part of speech for 'PUNCH'
[warning ZIL0308] <top level>: too many parts of speech for 'SLAP': Adjective (tower.zil:1402), Object (tower.zil:1403), Verb (syntax.zil:647)
[warning ZIL0306] tower.zil:1402: discarding the Adjective part of speech for 'SLAP'
[warning ZIL0308] <top level>: too many parts of speech for 'HIT': Adjective (tower.zil:1402), Object (tower.zil:1403), Verb (syntax.zil:647)
[warning ZIL0306] tower.zil:1402: discarding the Adjective part of speech for 'HIT'
[warning ZIL0308] <top level>: too many parts of speech for 'KICK': Adjective (tower.zil:1402), Object (tower.zil:1403), Verb (syntax.zil:647)
[warning ZIL0306] tower.zil:1402: discarding the Adjective part of speech for 'KICK'
[warning ZIL0308] <top level>: too many parts of speech for 'DRIVE': Adjective (castle.zil:326), Object (global.zil:646), Verb (syntax.zil:822)
[warning ZIL0306] castle.zil:326: discarding the Adjective part of speech for 'DRIVE'

I left one warning about an unused variable untouched, because removing it caused more warnings. (It's an optional parameter, and some calls specify it. But it's still not actually used...)