the-infocom-files / moonmist

Moonmist
4 stars 3 forks source link

"OPEN LEVER" and "CLOSE LEVER" don't check if the door already is open/closed #43

Open eriktorbjorn opened 2 years ago

eriktorbjorn commented 2 years ago
>PULL LEVER
The secret door creaks open, revealing Hyde's bedroom!

>OPEN LEVER
Okay, the secret door is now open.

>OPEN LEVER
Okay, the secret door is now open.

>CLOSE LEVER
Okay, the secret door is now closed.

>CLOSE LEVER
Okay, the secret door is now closed.

That's because LEVER-F doesn't check:

          (<VERB? OPEN>
           <FSET .X ,TOUCHBIT ;,SEENBIT>
           <OKAY .X "open">
           <RTRUE>)
          (<VERB? CLOSE>
           <FSET .X ,TOUCHBIT ;,SEENBIT>
           <OKAY .X "closed">
           <RTRUE>)>>

Also, this way it doesn't tell what's on the other side when the door opens (like it does when you pull the lever), which seems a bit inconsistent.