search

the-infocom-files / seastalker

Seastalker
3 stars 3 forks source link

Missing newlines while Sharon explains #53

Open eriktorbjorn opened 4 years ago

eriktorbjorn commented 4 years ago

This part of the text is printed by the appropriately named SHARON-EXPLAINS routine:

Sharon says, "Notice how we keep 5 meters to the monster's right and 5 meters
behind its nose. The Sea Cat is programmed that way, so the signals reach the
monster with enough strength to keep it in control.""Was it out of control when
it attacked the Aquadome?" asks Tip.

There really should be a newline between the two messages. As it is, we have two quotation marks next to each other, without so much as a space. It's printed by this part:

    <SHARON-ABOUT-CAT>
    <TELL
"\"Was it out of control when it attacked the " D ,AQUADOME "?\" asks Tip.|
\"Oh no!\" Sharon replies. ">

``SHARON-ABOUT-CAT``` doesn't print a newline:

<ROUTINE SHARON-ABOUT-CAT ()
    <TELL
"Sharon says, \"Notice how we keep 5 meters to the monster's right and 5
meters behind its nose.
The Sea Cat is programmed that way, so the signals reach
the monster with enough strength to keep it in control.\"">>
eriktorbjorn commented 4 years ago 
>ASK SHARON ABOUT SNARK
"It's sensitive to the signals on its RIGHT side. Thorpe has installed a sonar
transducer on the LEFT or PORT side of this sub. He has to stay on the same side
of the monster all the time."
>ASK SHARON ABOUT SEA CAT
Sharon says, "Notice how we keep 5 meters to the monster's right and 5 meters
behind its nose. The Sea Cat is programmed that way, so the signals reach the
monster with enough strength to keep it in control."
>

So both SHARON-ABOUT-MONSTER and SHARON-ABOUT-CAT should definitely print a newline at the end.

eriktorbjorn commented 4 years ago

And I just noticed that there is a newline missing earlier in the text as well:

"Sharon, how does Thorpe control the monster?"
"By sonar pulse signals," she replies. "It's sensitive to the signals on its
RIGHT side. Thorpe has installed a sonar transducer on the LEFT or PORT side of
this sub. He has to stay on the same side of the monster all the time.""Is the
transducer sending out signals now?" Tip asks her.
    <TELL
"\"Sharon, how does Thorpe control the monster?\"|
\"By sonar pulse signals,\" she replies. ">
    <SHARON-ABOUT-MONSTER>
    <TELL
"\"Is the transducer sending out signals now?\" Tip asks her.|
\"Yes, it operates all the time. Can you make out our position on your "
D ,SONARSCOPE "?\"|
\"Thanks to the " D ,FINE-GRID "!\" says Tip.">

Anyway, adding the aforementioned newlines to those two routines should take care of all these problems. I think.