search

the-infocom-files / zork1

Zork I: The Great Underground Empire
11 stars 3 forks source link

The game doesn't tell if the match was the only light source when it goes out #39

Open eriktorbjorn opened 5 years ago

eriktorbjorn commented 5 years ago

When the lamp or candles go out and it was the only light source, the game prints "You'd better have more light than from the ..."

If you blow out a match and it was the only light source, the game prints "It's pitch black in here!"

There is no similar message if the match goes out on its own and it was the only light source. That should be easy enough to fix in I-MATCH.

<ROUTINE I-MATCH ()
     <TELL "The match has gone out." CR>
     <FCLEAR ,MATCH ,FLAMEBIT>
     <FCLEAR ,MATCH ,ONBIT>
     <SETG LIT <LIT? ,HERE>>
     <RTRUE>>

The code used when you blow out the match yourself does this:

        <SETG LIT <LIT? ,HERE>>
        <COND (<NOT ,LIT> <TELL "It's pitch black in here!" CR>)>

But I haven't tested adding it here.

Maybe the message was printed automatically elsewhere at some point. But if so, it's not any longer.