search

the-james-burton / the-turbine

The turbine is a set of server-side components that perform automated technical analysis on stocks.
MIT License
15 stars 7 forks source link

Stop using the spring stomp broker relay until it supports reactor 3 #24

Closed the-james-burton closed 7 years ago

the-james-burton commented 7 years ago

I want to start using reactor 3 in this project. The spring stomp broker relay (see 26.4.7 Full-Featured Broker) requires reactor 2. Unfortunately, reactor 3 is not backward compatible and has the same maven co-ordinates (io.projectreactor:reactor-core). The stomp broker relay fails hard if reactor 3 is present instead of reactor 2.

According to the docs, spring-boot v2 will be using reactor 3, but there is no release date for that and M1 is not due until end of March 2017.

Therefore the best thing to do is for me to just stop using the broker and instead use the built in simple broker until the spring stomp broker relay is upgraded to use reactor 3.

the-james-burton commented 7 years ago

Raised: https://jira.spring.io/browse/SPR-15129

the-james-burton commented 7 years ago

Done. There was a minor quirk: AngularStompDK in atacama doesn't seem to pass the credentials on to the server. I think this is a limitation of SockJS, but I'm not sure.

Since this is (hopefully) a temporary situation, I have simply unsecured the websocket endpoints and it all works fine.